Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2475433005: [turbofan] Refactor the compare-zero folding in instruction selector. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Refactor the compare-zero folding in instruction selector. Committed: https://crrev.com/9b308dcaf5ce0597a2acfd85d7104ed263c472aa Cr-Commit-Position: refs/heads/master@{#40721}

Patch Set 1 #

Patch Set 2 : Make mips64 happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -89 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 3 chunks +21 lines, -23 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-03 11:53:56 UTC) #8
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-03 12:28:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475433005/20001
4 years, 1 month ago (2016-11-03 12:28:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 12:30:36 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:23 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b308dcaf5ce0597a2acfd85d7104ed263c472aa
Cr-Commit-Position: refs/heads/master@{#40721}

Powered by Google App Engine
This is Rietveld 408576698