src/compiler/instruction-selector-impl.h - Issue 2475433005: [turbofan] Refactor the compare-zero folding in instruction selector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction-selector-impl.h

Issue 2475433005: [turbofan] Refactor the compare-zero folding in instruction selector. (Closed)

Patch Set: Make mips64 happy Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/instruction-selector-impl.h

diff --git a/src/compiler/instruction-selector-impl.h b/src/compiler/instruction-selector-impl.h

index 673d1b0dcbfe68967ebbf54c8d581e21831e4994..6cb87ea0c06cd2ecff9da771ba60c997cb2c728b 100644

--- a/src/compiler/instruction-selector-impl.h

+++ b/src/compiler/instruction-selector-impl.h

@@ -387,6 +387,7 @@ class FlagsContinuation final {

void Overwrite(FlagsCondition condition) { condition_ = condition; }

void OverwriteAndNegateIfEqual(FlagsCondition condition) {

+ DCHECK(condition_ == kEqual || condition_ == kNotEqual);

bool negate = condition_ == kEqual;

condition_ = condition;

if (negate) Negate();