chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java - Issue 2475213002: Update the Google Search geolocation disclosure to make it more obvious.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

Issue 2475213002: Update the Google Search geolocation disclosure to make it more obvious. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

index d2caaac1b680df5e769878684d9955a940dee384..d2321aa6724d0a30f2dadc6d723114e06d2249d4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java

@@ -146,7 +146,7 @@ public class GeolocationHeader {

return "X-Geo: a " + locationBase64;

}

- static boolean hasGeolocationPermission(Context context) {

+ public static boolean hasGeolocationPermission(Context context) {

int pid = Process.myPid();

int uid = Process.myUid();

if (ApiCompatibilityUtils.checkPermission(