Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2475213002: Update the Google Search geolocation disclosure to make it more obvious. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 84c8a59eda50f5eb17408b1fbffe2ede92597d6a..7792040e04faab6c22c69585163b0a16de8834b6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -3227,6 +3227,13 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
&& !TextUtils.equals(getAppAssociatedWith(), packageName);
}
+ @CalledByNative
+ public boolean couldShowDefaultSearchGeolocationDisclosure() {
+ if (isIncognito()) return false;
+
+ return GeolocationHeader.hasGeolocationPermission(getWindowAndroid().getContext().get());
gone 2016/11/04 23:21:48 Confirmed with Ted that you don't actually need th
benwells 2016/11/07 08:36:06 Done.
+ }
+
private native void nativeInit();
private native void nativeDestroy(long nativeTabAndroid);
private native void nativeInitWebContents(long nativeTabAndroid, boolean incognito,

Powered by Google App Engine
This is Rietveld 408576698