Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2474593002: Float formats are allowed for CopyTexImage with EXT_color_buffer_float (Closed)

Created:
4 years, 1 month ago by qiankun
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Float formats are allowed for CopyTexImage with EXT_color_buffer_float BUG=612542 TEST=gpu_unittests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/bd9c65851a44e78989b39e6e75222f5b70499fc4 Cr-Commit-Position: refs/heads/master@{#429595}

Patch Set 1 #

Total comments: 8

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -3 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 1 chunk +124 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
qiankun
PTAL. https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode13699 gpu/command_buffer/service/gles2_cmd_decoder.cc:13699: GLenum read_format, GLenum read_type) { May I add ...
4 years, 1 month ago (2016-11-02 10:30:05 UTC) #3
Zhenyao Mo
lgtm https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode13699 gpu/command_buffer/service/gles2_cmd_decoder.cc:13699: GLenum read_format, GLenum read_type) { On 2016/11/02 10:30:05, ...
4 years, 1 month ago (2016-11-02 18:26:09 UTC) #5
Kai Ninomiya
https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc (right): https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc#newcode2702 gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc:2702: command_line.AppendSwitch(switches::kEnableUnsafeES3APIs); On 2016/11/02 18:26:09, Zhenyao Mo wrote: > Again, ...
4 years, 1 month ago (2016-11-02 18:47:34 UTC) #6
Ken Russell (switch to Gerrit)
I defer to zmo's review.
4 years, 1 month ago (2016-11-02 20:33:45 UTC) #7
Kai Ninomiya
https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc (right): https://codereview.chromium.org/2474593002/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc#newcode2702 gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc:2702: command_line.AppendSwitch(switches::kEnableUnsafeES3APIs); On 2016/11/02 18:47:34, Kai Ninomiya wrote: > On ...
4 years, 1 month ago (2016-11-03 02:11:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474593002/20001
4 years, 1 month ago (2016-11-03 09:58:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 11:59:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474593002/20001
4 years, 1 month ago (2016-11-03 15:22:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 15:27:22 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 15:41:01 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd9c65851a44e78989b39e6e75222f5b70499fc4
Cr-Commit-Position: refs/heads/master@{#429595}

Powered by Google App Engine
This is Rietveld 408576698