Float formats are allowed for CopyTexImage with EXT_color_buffer_float

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 13678 matching lines @@
   }
 
   // This may be a slow command.  Exit command processing to allow for
   // context preemption and GPU watchdog checks.
   ExitCommandProcessingEarly();
   return error::kNoError;
 }
 
 bool GLES2DecoderImpl::ValidateCopyTexFormat(
     const char* func_name, GLenum internal_format,
     GLenum read_format, GLenum read_type) {

[qiankun, 2016/11/02 10:30:05]

May I add an argument like "report_msg" to control report message or not and
move this function to public. ValidateCopyTexFormat can be used to check if
glCopyTexImage2D can be used for glCopyTextureCHROMIUM. If not, there will be
some duplicated code.

[Zhenyao Mo, 2016/11/02 18:26:08]

Looks like this function always generates INVALID_OPERATION.  What about adding
a helper function that doesn't generate GL error, but return true/false with an
error message? Then another function to simply call the helper, and if false,
generate INVALID_OPERATION with the right message.

   if (read_format == 0) {
     LOCAL_SET_GL_ERROR(
         GL_INVALID_OPERATION, func_name, "no valid color image");
     return false;
   }
   // Check we have compatible formats.
   uint32_t channels_exist = GLES2Util::GetChannelsForFormat(read_format);
   uint32_t channels_needed = GLES2Util::GetChannelsForFormat(internal_format);
   if (!channels_needed ||
       (channels_needed & channels_exist) != channels_needed) {
     LOCAL_SET_GL_ERROR(
         GL_INVALID_OPERATION, func_name, "incompatible format");
     return false;
   }
   if (feature_info_->IsES3Enabled()) {
     GLint color_encoding = GetColorEncodingFromInternalFormat(read_format);
+    bool float_mismatch= feature_info_->ext_color_buffer_float_available() ?
+        (GLES2Util::IsIntegerFormat(internal_format) !=
+         GLES2Util::IsIntegerFormat(read_format)) :
+        GLES2Util::IsFloatFormat(internal_format);
     if (color_encoding != GetColorEncodingFromInternalFormat(internal_format) ||
-        GLES2Util::IsFloatFormat(internal_format) ||
+        float_mismatch ||
         (GLES2Util::IsSignedIntegerFormat(internal_format) !=
          GLES2Util::IsSignedIntegerFormat(read_format)) ||
         (GLES2Util::IsUnsignedIntegerFormat(internal_format) !=
          GLES2Util::IsUnsignedIntegerFormat(read_format))) {
       LOCAL_SET_GL_ERROR(
           GL_INVALID_OPERATION, func_name, "incompatible format");
       return false;
     }
   }
   if ((channels_needed & (GLES2Util::kDepth | GLES2Util::kStencil)) != 0) {
@@ skipping 5042 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu