Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2474523003: fix #27607, add dev_compiler summary to the SDK and move JS files (Closed)

Created:
4 years, 1 month ago by Jennifer Messerly
Modified:
4 years, 1 month ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27607, add dev_compiler summary to the SDK and move JS files R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/2e8d011ca328946732ab662fd7c273fcf4d34170

Patch Set 1 #

Patch Set 2 : wip #

Total comments: 2

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -79 lines) Patch
D pkg/dev_compiler/lib/runtime/dart_sdk.sum View Binary file 0 comments Download
A pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/analyzer/context.dart View 2 chunks +22 lines, -9 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/command.dart View 1 2 1 chunk +11 lines, -5 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 7 chunks +18 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/module_builder.dart View 5 chunks +14 lines, -20 lines 0 comments Download
M pkg/dev_compiler/lib/src/js_ast/js_ast.dart View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/dev_compiler/lib/src/js_ast/module_transform.dart View 1 chunk +0 lines, -25 lines 0 comments Download
M pkg/dev_compiler/test/codegen_test.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/build_pkgs.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/build_sdk.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/build_test_pkgs.sh View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/web/web_command.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
Hi Vijay, this fixes https://github.com/dart-lang/sdk/issues/27607. DDC summaries will always be used by DDC, and the ...
4 years, 1 month ago (2016-11-02 00:24:30 UTC) #2
vsm
lgtm https://codereview.chromium.org/2474523003/diff/20001/pkg/dev_compiler/lib/src/compiler/command.dart File pkg/dev_compiler/lib/src/compiler/command.dart (right): https://codereview.chromium.org/2474523003/diff/20001/pkg/dev_compiler/lib/src/compiler/command.dart#newcode166 pkg/dev_compiler/lib/src/compiler/command.dart:166: // place next to ever compiled module ever ...
4 years, 1 month ago (2016-11-02 00:46:49 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/2474523003/diff/20001/pkg/dev_compiler/lib/src/compiler/command.dart File pkg/dev_compiler/lib/src/compiler/command.dart (right): https://codereview.chromium.org/2474523003/diff/20001/pkg/dev_compiler/lib/src/compiler/command.dart#newcode166 pkg/dev_compiler/lib/src/compiler/command.dart:166: // place next to ever compiled module On 2016/11/02 ...
4 years, 1 month ago (2016-11-02 01:16:41 UTC) #4
Jennifer Messerly
4 years, 1 month ago (2016-11-02 01:17:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2e8d011ca328946732ab662fd7c273fcf4d34170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698