Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: pkg/dev_compiler/test/codegen_test.dart

Issue 2474523003: fix #27607, add dev_compiler summary to the SDK and move JS files (Closed)
Patch Set: fix typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/src/js_ast/module_transform.dart ('k') | pkg/dev_compiler/tool/build_pkgs.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/codegen_test.dart
diff --git a/pkg/dev_compiler/test/codegen_test.dart b/pkg/dev_compiler/test/codegen_test.dart
index 1f171f09e763811ec1a8c96ea653af5f595eebcf..5c215e027300e93fa90b29f3c54a1c4a74d91790 100644
--- a/pkg/dev_compiler/test/codegen_test.dart
+++ b/pkg/dev_compiler/test/codegen_test.dart
@@ -68,7 +68,7 @@ main(List<String> arguments) {
var sdkDir = path.join(repoDirectory, 'gen', 'patched_sdk');
var sdkSummaryFile =
- path.join(testDirectory, '..', 'lib', 'js', 'amd', 'dart_sdk.sum');
+ path.join(testDirectory, '..', 'lib', 'sdk', 'ddc_sdk.sum');
var summaryPaths = new Directory(path.join(codegenOutputDir, 'pkg'))
.listSync()
@@ -174,7 +174,7 @@ void _writeModule(String outPath, String expectPath, ModuleFormat format,
if (errors.isNotEmpty && !errors.endsWith('\n')) errors += '\n';
new File(outPath + '.txt').writeAsStringSync(errors);
- result.writeCodeSync(format, false, outPath + '.js');
+ result.writeCodeSync(format, outPath + '.js');
if (result.summaryBytes != null) {
new File(outPath + '.sum').writeAsBytesSync(result.summaryBytes);
@@ -188,7 +188,7 @@ void _writeModule(String outPath, String expectPath, ModuleFormat format,
var expectFile = new File(expectPath + '.js');
if (result.isValid) {
- result.writeCodeSync(format, false, expectFile.path);
+ result.writeCodeSync(format, expectFile.path);
} else {
expectFile.writeAsStringSync("//FAILED TO COMPILE");
}
« no previous file with comments | « pkg/dev_compiler/lib/src/js_ast/module_transform.dart ('k') | pkg/dev_compiler/tool/build_pkgs.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698