Issue 2474433009: ash: Avoid a shutdown crash in ScreenRotationAnimation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2474433009: ash: Avoid a shutdown crash in ScreenRotationAnimation. (Closed)

Created:
4 years, 1 month ago by Daniel Erat

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

ash: Avoid a shutdown crash in ScreenRotationAnimation. Make ash::ScreenRotationAnimation::OnAbort() not dereference a null ui::LayerAnimationDelegate* when its layer is destroyed mid-animation. BUG=661313 Review-Url: https://codereview.chromium.org/2473523003 Cr-Commit-Position: refs/heads/master@{#429277} (cherry picked from commit ee91b8bf594ec33c709a2a9826569fdd88ed98bd) Committed: https://chromium.googlesource.com/chromium/src/+/f9ac2119692494dbc0a19be5181369d9670b1b6d

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -1 line)			Patch
M	ash/rotator/screen_rotation_animation.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/rotator/screen_rotation_animation.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/rotator/screen_rotation_animation_unittest.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Daniel Erat

4 years, 1 month ago (2016-11-03 15:25:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f9ac2119692494dbc0a19be5181369d9670b1b6d.