ash: Avoid a shutdown crash in ScreenRotationAnimation.

ash: Avoid a shutdown crash in ScreenRotationAnimation.

Make ash::ScreenRotationAnimation::OnAbort() not dereference
a null ui::LayerAnimationDelegate* when its layer is
destroyed mid-animation.

BUG=661313
Committed: https://crrev.com/ee91b8bf594ec33c709a2a9826569fdd88ed98bd
Cr-Commit-Position: refs/heads/master@{#429277}

[Daniel Erat, 2016-11-02 00:36:06]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[Daniel Erat, 2016-11-02 00:36:22]

derat@chromium.org changed reviewers:
+ bruthig@chromium.org, jamescook@chromium.org

[commit-bot: I haz the power, 2016-11-02 00:36:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 01:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 01:12:50]

Dry run: This issue passed the CQ dry run.

[bruthig, 2016-11-02 01:38:29]

On 2016/11/02 00:36:23, Daniel Erat wrote:

Part of me wonders if having Layer::~Layer() call
animator_->AbortAllAnimations() would be a better fix but then you'd be causing
virtual Layer functions to be called during destruction.  So all in all this is
probably better.

Can you update the LayerAnimationElement::OnAbort() docs to say that |delegate|
can be null?

lgtm

[James Cook, 2016-11-02 02:19:17]

LGTM with nits

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animation.cc (right):

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animation.cc:69: }
Can you also fix the bad "// Implementation of ui::LayerAnimationDelegate"
comment in the header?

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animation_unittest.cc (right):

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animation_unittest.cc:94: layer.reset();
not needed? or comment that you're explicitly destroying it because that's what
you're testing? both?

[Daniel Erat, 2016-11-02 14:04:05]

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animation.cc (right):

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animation.cc:69: }
On 2016/11/02 02:19:17, James Cook wrote:
> Can you also fix the bad "// Implementation of ui::LayerAnimationDelegate"
> comment in the header?

Done.

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animation_unittest.cc (right):

https://codereview.chromium.org/2473523003/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animation_unittest.cc:94: layer.reset();
On 2016/11/02 02:19:17, James Cook wrote:
> not needed? or comment that you're explicitly destroying it because that's
what
> you're testing? both?

Done. (kept this because if this starts failing, it makes it clearer to readers
that this is what's being tested rather than just being a test-teardown/ordering
bug that's causing a crash)

[Daniel Erat, 2016-11-02 14:04:20]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2016-11-02 14:04:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2473523003/#ps20001
(title: "address review comments")

[commit-bot: I haz the power, 2016-11-02 14:04:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 14:37:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 14:40:59]

Description was changed from

==========
ash: Avoid a shutdown crash in ScreenRotationAnimation.

Make ash::ScreenRotationAnimation::OnAbort() not dereference
a null ui::LayerAnimationDelegate* when its layer is
destroyed mid-animation.

BUG=661313
==========

to

==========
ash: Avoid a shutdown crash in ScreenRotationAnimation.

Make ash::ScreenRotationAnimation::OnAbort() not dereference
a null ui::LayerAnimationDelegate* when its layer is
destroyed mid-animation.

BUG=661313

Committed: https://crrev.com/ee91b8bf594ec33c709a2a9826569fdd88ed98bd
Cr-Commit-Position: refs/heads/master@{#429277}
==========

[commit-bot: I haz the power, 2016-11-02 14:41:00]

Patchset 2 (id:??) landed as
https://crrev.com/ee91b8bf594ec33c709a2a9826569fdd88ed98bd
Cr-Commit-Position: refs/heads/master@{#429277}