Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2474363002:
MacViews/a11y: Accessibility actions use AXActionData in AXPlatformNodeDelegate. (Closed)
|
Created:
4 years, 1 month ago by Patti Lor Modified:
4 years, 1 month ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tfarina, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility.
Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for
all possible accessibility actions. To support 'unfocusing' a control, also add
a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS.
Existing accessibility actions which previously had their own methods on
AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction.
This follows up r426221, which did the same thing for accessibility actions
inside the web contents area. To be consistent, use the same
AccessibilityPerformAction method signature.
BUG=662064
Committed: https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df
Cr-Commit-Position: refs/heads/master@{#433717}
Patch Set 1 #Patch Set 2 : Adjust method signature to match up with BrowserAccessibilityManager. #Patch Set 3 : Rebase and get rid of a bunch of non-general accessibility action methods on AXPlatformNodeDelegate. #Patch Set 4 : Fix all of the compile errors. #Patch Set 5 : Fix Chrome OS. #Patch Set 6 : Fix Linux. #
Total comments: 8
Patch Set 7 : Review comments. #Patch Set 8 : Return things to prevent compile errors. #
Total comments: 10
Patch Set 9 : Review comments. #
Total comments: 10
Patch Set 10 : Review comments. #Depends on Patchset: Messages
Total messages: 73 (62 generated)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== MacViews/a11y: Accessibility actions use AXActionData in AXPlatformNodeDelegate. Refactor AXPlatformNodeDelegate and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support writing the selected text or inserting text at the cursor, also add a new action ui::AX_ACTION_REPLACE_SELECTION. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction call. ========== to ========== MacViews/a11y: Accessibility actions use AXActionData in AXPlatformNodeDelegate. Refactor AXPlatformNodeDelegate and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support writing the selected text or inserting text at the cursor, also add a new action ui::AX_ACTION_REPLACE_SELECTION. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction call. ==========
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Patchset #6 (id:100001) has been deleted
Patchset #4 (id:60001) has been deleted
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MacViews/a11y: Accessibility actions use AXActionData in AXPlatformNodeDelegate. Refactor AXPlatformNodeDelegate and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support writing the selected text or inserting text at the cursor, also add a new action ui::AX_ACTION_REPLACE_SELECTION. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction call. ========== to ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
patricialor@chromium.org changed reviewers: + tapted@chromium.org
Hey Trent, PTAL! Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Sorry for the delay! https://codereview.chromium.org/2474363002/diff/150001/ui/accessibility/platf... File ui/accessibility/platform/ax_platform_node_delegate.h (right): https://codereview.chromium.org/2474363002/diff/150001/ui/accessibility/platf... ui/accessibility/platform/ax_platform_node_delegate.h:93: virtual bool SetFocused(bool focused) = 0; Can this be removed at this level? (perhaps keep it as a non-virtual member on NativeViewAccessibility) https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:204: // Fallthrough. nit: we don't normally need Fallthrough when the cases are immediately adjacent https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:206: view_->HandleAccessibleAction(data); This returns a bool - I think we should communicate that back up to the caller. Then AXPlatformNodeWin::put_accValue can return E_FAIL when appropriate. https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:222: case ui::AX_ACTION_SET_SCROLL_OFFSET: Would these apply to views::ScrollView?
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks Trent, PTAL. https://codereview.chromium.org/2474363002/diff/150001/ui/accessibility/platf... File ui/accessibility/platform/ax_platform_node_delegate.h (right): https://codereview.chromium.org/2474363002/diff/150001/ui/accessibility/platf... ui/accessibility/platform/ax_platform_node_delegate.h:93: virtual bool SetFocused(bool focused) = 0; On 2016/11/18 04:45:40, tapted wrote: > Can this be removed at this level? (perhaps keep it as a non-virtual member on > NativeViewAccessibility) Done. https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:204: // Fallthrough. On 2016/11/18 04:45:40, tapted wrote: > nit: we don't normally need Fallthrough when the cases are immediately adjacent Done. https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:206: view_->HandleAccessibleAction(data); On 2016/11/18 04:45:40, tapted wrote: > This returns a bool - I think we should communicate that back up to the caller. > Then AXPlatformNodeWin::put_accValue can return E_FAIL when appropriate. Done. https://codereview.chromium.org/2474363002/diff/150001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:222: case ui::AX_ACTION_SET_SCROLL_OFFSET: On 2016/11/18 04:45:40, tapted wrote: > Would these apply to views::ScrollView? Yeah, I think so! Moved to the category above.
lgtm with a few things also is there a BUG= we can reference? https://codereview.chromium.org/2474363002/diff/190001/chrome/browser/ui/aura... File chrome/browser/ui/aura/accessibility/automation_manager_aura.cc (right): https://codereview.chromium.org/2474363002/diff/190001/chrome/browser/ui/aura... chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:118: case ui::AX_ACTION_BLUR: I'm not sure if this is the right place, but dmazonni should know :) https://codereview.chromium.org/2474363002/diff/190001/ui/accessibility/platf... File ui/accessibility/platform/ax_platform_node_delegate.h (right): https://codereview.chromium.org/2474363002/diff/190001/ui/accessibility/platf... ui/accessibility/platform/ax_platform_node_delegate.h:8: #include "ui/accessibility/ax_action_data.h" nit: forward declare (before AXNodeData) https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:193: break; return true? https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:195: SetFocused(true); return SetFocused? (if yes, break not required after). Same for AX_ACTION_BLUR https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:246: bool NativeViewAccessibility::SetFocused(bool focused) { nit: move this to match the declaration order
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
dmazzoni@chromium.org changed reviewers: + dmazzoni@chromium.org
lgtm https://codereview.chromium.org/2474363002/diff/210001/content/renderer/acces... File content/renderer/accessibility/render_accessibility_impl.cc (right): https://codereview.chromium.org/2474363002/diff/210001/content/renderer/acces... content/renderer/accessibility/render_accessibility_impl.cc:454: // TODO(dmazzoni): Implement this. It should be as simple as this: target.setFocused(false); https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/ax_en... File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/ax_en... ui/accessibility/ax_enums.idl:263: blur, nit: sort this alphabetically. it might be nice to rename set_focus to just focus so they're more consistent. (set_blur would sound weird) https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/platf... File ui/accessibility/platform/ax_platform_node_mac.mm (right): https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/platf... ui/accessibility/platform/ax_platform_node_mac.mm:412: node_->GetDelegate()->AccessibilityPerformAction(data); Only do this if |data| is set, or add an "else" clause just in case |value| is something else. Don't make it a fatal error - this is an external API and we should fail gracefully if passed an unexpected input - but don't make it possible to call AccessibilityPerformAction with no action set. https://codereview.chromium.org/2474363002/diff/210001/ui/views/accessibility... File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2474363002/diff/210001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:224: NOTIMPLEMENTED(); It might be better to just call view_->HandleAccessibleAction for everything else, that has its own switch. That way if a View ever wants to implement one of these, it won't have to modify this file again. https://codereview.chromium.org/2474363002/diff/210001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:229: case ui::AX_ACTION_NONE: nit: the comment above implies AX_ACTION_NONE is used on the web, but it's not an action at all, it shouldn't ever be reached
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. ========== to ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. BUG=662064 ==========
patricialor@chromium.org changed reviewers: + sky@chromium.org
Thanks both for the reviews - tapted@ I've referenced https://bugs.chromium.org/p/chromium/issues/detail?id=662064 as this was the original bug dmazzoni used for r426221 (as mentioned in the CL description). sky@ - PTAL for OWNER's review of chrome/browser/extensions/api/automation_internal/automation_internal_api.cc Thanks! https://codereview.chromium.org/2474363002/diff/190001/chrome/browser/ui/aura... File chrome/browser/ui/aura/accessibility/automation_manager_aura.cc (right): https://codereview.chromium.org/2474363002/diff/190001/chrome/browser/ui/aura... chrome/browser/ui/aura/accessibility/automation_manager_aura.cc:118: case ui::AX_ACTION_BLUR: On 2016/11/21 02:15:43, tapted wrote: > I'm not sure if this is the right place, but dmazonni should know :) Acknowledged. https://codereview.chromium.org/2474363002/diff/190001/ui/accessibility/platf... File ui/accessibility/platform/ax_platform_node_delegate.h (right): https://codereview.chromium.org/2474363002/diff/190001/ui/accessibility/platf... ui/accessibility/platform/ax_platform_node_delegate.h:8: #include "ui/accessibility/ax_action_data.h" On 2016/11/21 02:15:43, tapted wrote: > nit: forward declare (before AXNodeData) Done. https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:193: break; On 2016/11/21 02:15:43, tapted wrote: > return true? Done. https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:195: SetFocused(true); On 2016/11/21 02:15:43, tapted wrote: > return SetFocused? (if yes, break not required after). Same for AX_ACTION_BLUR Done. https://codereview.chromium.org/2474363002/diff/190001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:246: bool NativeViewAccessibility::SetFocused(bool focused) { On 2016/11/21 02:15:43, tapted wrote: > nit: move this to match the declaration order Done, thanks! https://codereview.chromium.org/2474363002/diff/210001/content/renderer/acces... File content/renderer/accessibility/render_accessibility_impl.cc (right): https://codereview.chromium.org/2474363002/diff/210001/content/renderer/acces... content/renderer/accessibility/render_accessibility_impl.cc:454: // TODO(dmazzoni): Implement this. On 2016/11/21 04:53:38, dmazzoni wrote: > It should be as simple as this: > > target.setFocused(false); Done. https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/ax_en... File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/ax_en... ui/accessibility/ax_enums.idl:263: blur, On 2016/11/21 04:53:38, dmazzoni wrote: > nit: sort this alphabetically. it might be nice to rename set_focus to > just focus so they're more consistent. (set_blur would sound weird) Thanks, was going to ask you about this! Done. https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/platf... File ui/accessibility/platform/ax_platform_node_mac.mm (right): https://codereview.chromium.org/2474363002/diff/210001/ui/accessibility/platf... ui/accessibility/platform/ax_platform_node_mac.mm:412: node_->GetDelegate()->AccessibilityPerformAction(data); On 2016/11/21 04:53:38, dmazzoni wrote: > Only do this if |data| is set, or add an "else" clause just in case > |value| is something else. > > Don't make it a fatal error - this is an external API and we should fail > gracefully if passed an unexpected input - but don't make it possible > to call AccessibilityPerformAction with no action set. > > Now checking for AX_ACTION_NONE here, thanks. https://codereview.chromium.org/2474363002/diff/210001/ui/views/accessibility... File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2474363002/diff/210001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:224: NOTIMPLEMENTED(); On 2016/11/21 04:53:38, dmazzoni wrote: > It might be better to just call view_->HandleAccessibleAction > for everything else, that has its own switch. > > That way if a View ever wants to implement one of these, it > won't have to modify this file again. Done. https://codereview.chromium.org/2474363002/diff/210001/ui/views/accessibility... ui/views/accessibility/native_view_accessibility.cc:229: case ui::AX_ACTION_NONE: On 2016/11/21 04:53:38, dmazzoni wrote: > nit: the comment above implies AX_ACTION_NONE is used on the web, but it's > not an action at all, it shouldn't ever be reached Deleted!
Normally I would recommend getting a more local OWNER, but the change is trivial, so LGTM
Ah, will keep that in mind for next time. Thanks!
The CQ bit was checked by patricialor@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org, dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2474363002/#ps230001 (title: "Review comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 230001, "attempt_start_ts": 1479775092424020,
"parent_rev": "13eea00822c3f3bea2caa68fd3284cde1fd3c3cf", "commit_rev":
"6531c7d024491567b1adfe256248835e7532a4fd"}
Message was sent while issue was closed.
Description was changed from ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. BUG=662064 ========== to ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. BUG=662064 ==========
Message was sent while issue was closed.
Committed patchset #10 (id:230001)
Message was sent while issue was closed.
Description was changed from ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. BUG=662064 ========== to ========== MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility. Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for all possible accessibility actions. To support 'unfocusing' a control, also add a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS. Existing accessibility actions which previously had their own methods on AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction. This follows up r426221, which did the same thing for accessibility actions inside the web contents area. To be consistent, use the same AccessibilityPerformAction method signature. BUG=662064 Committed: https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df Cr-Commit-Position: refs/heads/master@{#433717} ==========
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df Cr-Commit-Position: refs/heads/master@{#433717} |
