chrome/browser/sync/profile_sync_components_factory.h - Issue 247433004: sync: remove CreateSharedChangeProcessor from ProfileSyncComponentsFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory.h

Issue 247433004: sync: remove CreateSharedChangeProcessor from ProfileSyncComponentsFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove SCPFactory Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/ui_data_type_controller_unittest.cc ('k') | chrome/browser/sync/profile_sync_components_factory_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_components_factory.h

diff --git a/chrome/browser/sync/profile_sync_components_factory.h b/chrome/browser/sync/profile_sync_components_factory.h

index bf266710acbb9b24f3feb2b4ab3857859e4b8418..a9329e28c0a316744d89f435361ab8821060e335 100644

--- a/chrome/browser/sync/profile_sync_components_factory.h

+++ b/chrome/browser/sync/profile_sync_components_factory.h

@@ -28,7 +28,6 @@ class DataTypeManager;

class DataTypeManagerObserver;

class FailedDataTypesHandler;

class GenericChangeProcessor;

-class SharedChangeProcessor;

class SyncBackendHost;

class DataTypeErrorHandler;

} // namespace browser_sync

@@ -102,9 +101,6 @@ class ProfileSyncComponentsFactory

const base::WeakPtr<syncer::SyncableService>& local_service,

const base::WeakPtr<syncer::SyncMergeResult>& merge_result) = 0;

- virtual browser_sync::SharedChangeProcessor*

- CreateSharedChangeProcessor() = 0;

// Legacy datatypes that need to be converted to the SyncableService API.

virtual SyncComponents CreateBookmarkSyncComponents(

ProfileSyncService* profile_sync_service,