Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory.h

Issue 247433004: sync: remove CreateSharedChangeProcessor from ProfileSyncComponentsFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove SCPFactory Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 10 matching lines...) Expand all
21 class WebDataService; 21 class WebDataService;
22 22
23 namespace browser_sync { 23 namespace browser_sync {
24 class AssociatorInterface; 24 class AssociatorInterface;
25 class ChangeProcessor; 25 class ChangeProcessor;
26 class DataTypeEncryptionHandler; 26 class DataTypeEncryptionHandler;
27 class DataTypeManager; 27 class DataTypeManager;
28 class DataTypeManagerObserver; 28 class DataTypeManagerObserver;
29 class FailedDataTypesHandler; 29 class FailedDataTypesHandler;
30 class GenericChangeProcessor; 30 class GenericChangeProcessor;
31 class SharedChangeProcessor;
32 class SyncBackendHost; 31 class SyncBackendHost;
33 class DataTypeErrorHandler; 32 class DataTypeErrorHandler;
34 } // namespace browser_sync 33 } // namespace browser_sync
35 34
36 namespace sync_driver { 35 namespace sync_driver {
37 class SyncPrefs; 36 class SyncPrefs;
38 } 37 }
39 38
40 namespace syncer { 39 namespace syncer {
41 class DataTypeDebugInfoListener; 40 class DataTypeDebugInfoListener;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 Profile* profile, 94 Profile* profile,
96 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs) = 0; 95 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs) = 0;
97 96
98 // Creating this in the factory helps us mock it out in testing. 97 // Creating this in the factory helps us mock it out in testing.
99 virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor( 98 virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor(
100 ProfileSyncService* profile_sync_service, 99 ProfileSyncService* profile_sync_service,
101 browser_sync::DataTypeErrorHandler* error_handler, 100 browser_sync::DataTypeErrorHandler* error_handler,
102 const base::WeakPtr<syncer::SyncableService>& local_service, 101 const base::WeakPtr<syncer::SyncableService>& local_service,
103 const base::WeakPtr<syncer::SyncMergeResult>& merge_result) = 0; 102 const base::WeakPtr<syncer::SyncMergeResult>& merge_result) = 0;
104 103
105 virtual browser_sync::SharedChangeProcessor*
106 CreateSharedChangeProcessor() = 0;
107
108 // Legacy datatypes that need to be converted to the SyncableService API. 104 // Legacy datatypes that need to be converted to the SyncableService API.
109 virtual SyncComponents CreateBookmarkSyncComponents( 105 virtual SyncComponents CreateBookmarkSyncComponents(
110 ProfileSyncService* profile_sync_service, 106 ProfileSyncService* profile_sync_service,
111 browser_sync::DataTypeErrorHandler* error_handler) = 0; 107 browser_sync::DataTypeErrorHandler* error_handler) = 0;
112 virtual SyncComponents CreateTypedUrlSyncComponents( 108 virtual SyncComponents CreateTypedUrlSyncComponents(
113 ProfileSyncService* profile_sync_service, 109 ProfileSyncService* profile_sync_service,
114 history::HistoryBackend* history_backend, 110 history::HistoryBackend* history_backend,
115 browser_sync::DataTypeErrorHandler* error_handler) = 0; 111 browser_sync::DataTypeErrorHandler* error_handler) = 0;
116 }; 112 };
117 113
118 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__ 114 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698