Issue 247433002: Use GradFlags for gradient Flags in SkGradientShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247433002: Use GradFlags for gradient Flags in SkGradientShader (Closed)

Created:
6 years, 8 months ago by egdaniel

Modified:
6 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, Dominik Grewe

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Use GradFlags for gradient Flags in SkGradientShader This is done to avoid confusion with other Flag variable used for alpha type in shader BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14298

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/effects/gradients/SkGradientShader.cpp	View		3 chunks	+8 lines, -8 lines	0 comments	Download
	M	src/effects/gradients/SkGradientShaderPriv.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/247433002/1

6 years, 8 months ago (2014-04-22 15:14:06 UTC) #4

Message was sent while issue was closed.

Change committed as 14298

Expand Messages | Collapse Messages