Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: content/browser/web_contents/web_contents_view_guest.cc

Issue 2474323002: Implement WebContentsViewChildFrame::TakeFocus. (Closed)
Patch Set: Conflicted with my own cl https://codereview.chromium.org/2455133005/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_guest.h" 5 #include "content/browser/web_contents/web_contents_view_guest.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "content/browser/browser_plugin/browser_plugin_embedder.h" 10 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 RenderViewHostDelegateView* view = 210 RenderViewHostDelegateView* view =
211 embedder_render_view_host->GetDelegate()->GetDelegateView(); 211 embedder_render_view_host->GetDelegate()->GetDelegateView();
212 if (view) 212 if (view)
213 view->UpdateDragCursor(operation); 213 view->UpdateDragCursor(operation);
214 } 214 }
215 215
216 void WebContentsViewGuest::GotFocus() { 216 void WebContentsViewGuest::GotFocus() {
217 } 217 }
218 218
219 void WebContentsViewGuest::TakeFocus(bool reverse) { 219 void WebContentsViewGuest::TakeFocus(bool reverse) {
220 LOG(ERROR) << this << "WebContentsViewChildFrame::TakeFocus: " << reverse;
alexmos 2016/11/22 02:45:27 Don't forget to remove. And by the way, does the
avallee 2016/11/25 19:39:54 No, ViewHostMsg_TakeFocus is handled by BrowserPlu
alexmos 2016/11/28 23:52:23 Acknowledged.
220 } 221 }
221 222
222 void WebContentsViewGuest::ShowContextMenu(RenderFrameHost* render_frame_host, 223 void WebContentsViewGuest::ShowContextMenu(RenderFrameHost* render_frame_host,
223 const ContextMenuParams& params) { 224 const ContextMenuParams& params) {
224 platform_view_delegate_view_->ShowContextMenu(render_frame_host, params); 225 platform_view_delegate_view_->ShowContextMenu(render_frame_host, params);
225 } 226 }
226 227
227 void WebContentsViewGuest::StartDragging( 228 void WebContentsViewGuest::StartDragging(
228 const DropData& drop_data, 229 const DropData& drop_data,
229 WebDragOperationsMask ops, 230 WebDragOperationsMask ops,
(...skipping 12 matching lines...) Expand all
242 if (view) { 243 if (view) {
243 RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.StartDrag")); 244 RecordAction(base::UserMetricsAction("BrowserPlugin.Guest.StartDrag"));
244 view->StartDragging( 245 view->StartDragging(
245 drop_data, ops, image, image_offset, event_info, source_rwh); 246 drop_data, ops, image, image_offset, event_info, source_rwh);
246 } else { 247 } else {
247 embedder_web_contents->SystemDragEnded(source_rwh); 248 embedder_web_contents->SystemDragEnded(source_rwh);
248 } 249 }
249 } 250 }
250 251
251 } // namespace content 252 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698