Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247423002: [oilpan]: Change all modules files to include platform/heap/... instead of heap/... (Closed)

Created:
6 years, 8 months ago by wibling-chromium
Modified:
6 years, 8 months ago
CC:
blink-reviews, timvolodine, nhiroki, serviceworker-reviews, ericu+idb_chromium.org, feature-media-reviews_chromium.org, falken, philipj_slow, alecflett, jsbell+serviceworker_chromium.org, eric.carlson_apple.com, kinuko, mvanouwerkerk+watch_chromium.org, tommyw+watchlist_chromium.org, tzik, Inactive, cmumford, horo+watch_chromium.org, dgrogan, jsbell+idb_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -136 lines) Patch
M Source/modules/battery/BatteryManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/battery/NavigatorBattery.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/AesKeyAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Crypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Key.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/KeyAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/KeyPair.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceAcceleration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceRotationRate.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/donottrack/NavigatorDoNotTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystemSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DataTransferItemFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryEntry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryReader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryReaderBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryReaderSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DraggedIsolatedFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/EntriesCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/Entry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/EntryBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/EntrySync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileEntry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileEntrySync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriterBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriterSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/HTMLInputElementFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/InspectorFileSystemAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/filesystem/InspectorFrontendHostFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/Metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/SyncCallbackHelper.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/Gamepad.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/GamepadButton.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepad.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepadList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/Coordinates.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/Geoposition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/NavigatorGeolocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/PositionError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/PositionOptions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabaseCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/HTMLVideoElementMediaSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/VideoPlaybackQuality.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/SharedWorkerPerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/WorkerGlobalScopePerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/performance/WorkerPerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/NavigatorPushManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DOMWindowQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammar.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammarList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisVoice.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/AbstractDatabaseServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/AbstractSQLStatementBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/AbstractSQLTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/AbstractSQLTransactionBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/ChangeVersionWrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseAuthorizer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTask.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLResultSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLResultSetRowList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackendSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionCoordinator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIInput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
wibling-chromium
Trivial change to make modules files include the platform/heap/Handle.h header file directly instead of via ...
6 years, 8 months ago (2014-04-22 13:35:23 UTC) #1
haraken
rubberstamp LGTM!
6 years, 8 months ago (2014-04-22 13:46:21 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 8 months ago (2014-04-22 13:46:51 UTC) #3
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 8 months ago (2014-04-22 13:49:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/247423002/1
6 years, 8 months ago (2014-04-22 13:49:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 14:25:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-22 14:25:06 UTC) #7
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 8 months ago (2014-04-22 15:04:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/247423002/1
6 years, 8 months ago (2014-04-22 15:04:12 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 15:46:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 172146

Powered by Google App Engine
This is Rietveld 408576698