Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2474183002: MD Settings: fix up UMA restart button visual nits (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix up UMA restart button visual nits R=tommycli@chromium.org BUG=653791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f8fcdf3b8d305f5fe48313b20e251300d5ff474c Cr-Commit-Position: refs/heads/master@{#429756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2468173004 Patch 1

Messages

Total messages: 17 (10 generated)
Dan Beam
4 years, 1 month ago (2016-11-03 19:34:48 UTC) #4
tommycli
lgtm
4 years, 1 month ago (2016-11-03 20:08:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474183002/1
4 years, 1 month ago (2016-11-03 20:30:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/255894)
4 years, 1 month ago (2016-11-03 23:20:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474183002/1
4 years, 1 month ago (2016-11-03 23:26:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 01:38:14 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 01:39:56 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f8fcdf3b8d305f5fe48313b20e251300d5ff474c
Cr-Commit-Position: refs/heads/master@{#429756}

Powered by Google App Engine
This is Rietveld 408576698