MD Settings: show restart button when user toggles metrics reporting

MD Settings: show restart button when user toggles metrics reporting

Note: this applies only to desktop. ChromeOS handles metrics reporting
differently.

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e739f75ea0d99971a7703e3a7793f97a418bd1b5
Cr-Commit-Position: refs/heads/master@{#429527}

[Dan Beam, 2016-11-03 00:15:34]

Description was changed from

==========
MD Settings: show restart button when user toggles metrics reporting

R=dpapad@chromium.org
BUG=653791
==========

to

==========
MD Settings: show restart button when user toggles metrics reporting

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-03 00:16:37]

Description was changed from

==========
MD Settings: show restart button when user toggles metrics reporting

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: show restart button when user toggles metrics reporting

Note: this applies only to desktop. ChromeOS handles metrics reporting
differently.

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-03 00:22:55]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:23:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-11-03 01:32:38]

LGTM

https://codereview.chromium.org/2468173004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/2468173004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:36: /** @type
{MetricsReporting} */
?MetricsReporting

https://codereview.chromium.org/2468173004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:120: //
TODO(dbeam): hide if changed back to the value Chrome started with.
Eh, is that too hard to do now? Just need an extra boolean, right?

[Dan Beam, 2016-11-03 01:38:32]

https://codereview.chromium.org/2468173004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/2468173004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:36: /** @type
{MetricsReporting} */
On 2016/11/03 01:32:38, dpapad wrote:
> ?MetricsReporting

this isn't initially null, it's undefined

/** @type {Thing} */
var blah;
this.getBlah().then(function(blah) {
  blah = newBlah;
});

doesn't have a ? and some people put ! even though it's technically |undefined
until success

https://codereview.chromium.org/2468173004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.js:120: //
TODO(dbeam): hide if changed back to the value Chrome started with.
On 2016/11/03 01:32:38, dpapad wrote:
> Eh, is that too hard to do now? Just need an extra boolean, right?

to do correctly, we need to do this on chrome startup from the metrics code

see: how GPU acceleration works

[Dan Beam, 2016-11-03 04:02:03]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-11-03 04:02:08]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-11-03 04:02:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 05:00:38]

Description was changed from

==========
MD Settings: show restart button when user toggles metrics reporting

Note: this applies only to desktop. ChromeOS handles metrics reporting
differently.

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: show restart button when user toggles metrics reporting

Note: this applies only to desktop. ChromeOS handles metrics reporting
differently.

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-03 05:00:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 05:03:07]

Description was changed from

==========
MD Settings: show restart button when user toggles metrics reporting

Note: this applies only to desktop. ChromeOS handles metrics reporting
differently.

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: show restart button when user toggles metrics reporting

Note: this applies only to desktop. ChromeOS handles metrics reporting
differently.

R=dpapad@chromium.org
BUG=653791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e739f75ea0d99971a7703e3a7793f97a418bd1b5
Cr-Commit-Position: refs/heads/master@{#429527}
==========

[commit-bot: I haz the power, 2016-11-03 05:03:08]

Patchset 1 (id:??) landed as
https://crrev.com/e739f75ea0d99971a7703e3a7793f97a418bd1b5
Cr-Commit-Position: refs/heads/master@{#429527}