Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 2474103003: DBC: Fix smi shl with large (>word-size) shift counts (Closed)

Created:
4 years, 1 month ago by Florian Schneider
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Fix smi shl with large (>word-size) shift counts Insert check to guard against large shift counts. Integer shifts with shift counts greater or equal than the number of bits per word are undefined behavior in C/C++. Fixes #27474. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/6fa4a54bba4c69bbd5fc15bc3ec50e4e8812776b

Patch Set 1 #

Patch Set 2 : better fix #

Patch Set 3 : update co19 test status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M runtime/vm/simulator_dbc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 1 month ago (2016-11-04 10:54:49 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-04 10:56:52 UTC) #3
Florian Schneider
Thanks. I had to update a co19 test which is now passing on simdbc as ...
4 years, 1 month ago (2016-11-04 11:15:56 UTC) #4
Florian Schneider
4 years, 1 month ago (2016-11-04 11:16:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6fa4a54bba4c69bbd5fc15bc3ec50e4e8812776b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698