runtime/vm/simulator_dbc.cc - Issue 2474103003: DBC: Fix smi shl with large (>word-size) shift counts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_dbc.cc

Issue 2474103003: DBC: Fix smi shl with large (>word-size) shift counts (Closed)

Patch Set: update co19 test status Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/simulator_dbc.cc

diff --git a/runtime/vm/simulator_dbc.cc b/runtime/vm/simulator_dbc.cc

index c02e1bfcaa5dfe5e11de27f647c661240756c608..c8908cb29bdd43d12b2a4d75ef40519ddb165052 100644

--- a/runtime/vm/simulator_dbc.cc

+++ b/runtime/vm/simulator_dbc.cc

@@ -1983,7 +1983,7 @@ RawObject* Simulator::Call(const Code& code,

{

BYTECODE(Shl, A_B_C);

const intptr_t rhs = reinterpret_cast<intptr_t>(FP[rC]) >> kSmiTagSize;

- if (rhs >= 0) {

+ if (static_cast<uintptr_t>(rhs) < kBitsPerWord) {

const intptr_t lhs = reinterpret_cast<intptr_t>(FP[rB]);

const intptr_t res = lhs << rhs;

if (lhs == (res >> rhs)) {

« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »