GN: Allow java_* to set their .jar name

GN: Allow java_* to set their .jar name

Use this new feature to remove cronet java target
naming exceptions from internal_rule.gni

BUG=620034
Committed: https://crrev.com/d827e0b95111780e9ce1c780aa16f0f6804b672d
Cr-Commit-Position: refs/heads/master@{#431086}

[agrieve, 2016-11-03 17:15:10]

agrieve@chromium.org changed reviewers:
+ mef@chromium.org

[agrieve, 2016-11-03 17:15:10]

🐸

[mef, 2016-11-04 20:17:05]

https://codereview.chromium.org/2474053003/diff/1/components/cronet/android/B...
File components/cronet/android/BUILD.gn (right):

https://codereview.chromium.org/2474053003/diff/1/components/cronet/android/B...
components/cronet/android/BUILD.gn:268: android_library("cronet_api_java") {
Would it be possible/better to override name of output jar file, so it will
continue to be called cronet_api.jar?

[agrieve, 2016-11-08 17:42:43]

Description was changed from

==========
Fix java target naming exceptions in cronet

BUG=620034
==========

to

==========
GN: Allow java_* to set their .jar name

Use this new feature to remove cronet java target
naming exceptions from internal_rule.gni

BUG=620034
==========

[agrieve, 2016-11-08 17:44:25]

+mikecase since this will make robolectric prebuilt naming easier.

https://codereview.chromium.org/2474053003/diff/1/components/cronet/android/B...
File components/cronet/android/BUILD.gn (right):

https://codereview.chromium.org/2474053003/diff/1/components/cronet/android/B...
components/cronet/android/BUILD.gn:268: android_library("cronet_api_java") {
On 2016/11/04 20:17:05, mef wrote:
> Would it be possible/better to override name of output jar file, so it will
> continue to be called cronet_api.jar?

Great idea. Done!

[mikecase (-- gone --), 2016-11-08 17:57:31]

On 2016/11/08 at 17:44:25, agrieve wrote:
> +mikecase since this will make robolectric prebuilt naming easier.
> 
>
https://codereview.chromium.org/2474053003/diff/1/components/cronet/android/B...
> File components/cronet/android/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2474053003/diff/1/components/cronet/android/B...
> components/cronet/android/BUILD.gn:268: android_library("cronet_api_java") {
> On 2016/11/04 20:17:05, mef wrote:
> > Would it be possible/better to override name of output jar file, so it will
> > continue to be called cronet_api.jar?
> 
> Great idea. Done!

This is great :D. ty

[mef, 2016-11-08 19:19:21]

lgtm

[agrieve, 2016-11-08 19:25:35]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:26:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:11:31]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-11-09 20:16:32]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 23:50:17]

Description was changed from

==========
GN: Allow java_* to set their .jar name

Use this new feature to remove cronet java target
naming exceptions from internal_rule.gni

BUG=620034
==========

to

==========
GN: Allow java_* to set their .jar name

Use this new feature to remove cronet java target
naming exceptions from internal_rule.gni

BUG=620034
==========

[commit-bot: I haz the power, 2016-11-09 23:50:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 23:57:52]

Description was changed from

==========
GN: Allow java_* to set their .jar name

Use this new feature to remove cronet java target
naming exceptions from internal_rule.gni

BUG=620034
==========

to

==========
GN: Allow java_* to set their .jar name

Use this new feature to remove cronet java target
naming exceptions from internal_rule.gni

BUG=620034

Committed: https://crrev.com/d827e0b95111780e9ce1c780aa16f0f6804b672d
Cr-Commit-Position: refs/heads/master@{#431086}
==========

[commit-bot: I haz the power, 2016-11-09 23:57:53]

Patchset 2 (id:??) landed as
https://crrev.com/d827e0b95111780e9ce1c780aa16f0f6804b672d
Cr-Commit-Position: refs/heads/master@{#431086}