Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2474053003: GN: Allow java_* to set their .jar name (Closed)
Patch Set: Implement output_name for java targets Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build_overrides/build.gni") 7 import("//build_overrides/build.gni")
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
(...skipping 16 matching lines...) Expand all
27 "*android*:resources", 27 "*android*:resources",
28 "*:*_resources", 28 "*:*_resources",
29 "*:*_grd", 29 "*:*_grd",
30 "*:*locale_paks", 30 "*:*locale_paks",
31 31
32 # TODO(agrieve): Rename targets below to match above patterns. 32 # TODO(agrieve): Rename targets below to match above patterns.
33 "*android_webview/glue:glue", 33 "*android_webview/glue:glue",
34 "//build/android/pylib/device/commands:chromium_commands", 34 "//build/android/pylib/device/commands:chromium_commands",
35 "//build/android/rezip:rezip", 35 "//build/android/rezip:rezip",
36 "//chrome/test/android/cast_emulator:cast_emulator", 36 "//chrome/test/android/cast_emulator:cast_emulator",
37 "//components/cronet/android:cronet_api",
38 "//components/cronet/android:cronet_javadoc_classpath",
39 "//mojo/public/java:bindings", 37 "//mojo/public/java:bindings",
40 "//third_party/android_tools:emma_device", 38 "//third_party/android_tools:emma_device",
41 "//third_party/cardboard-java:cardboard-java", 39 "//third_party/cardboard-java:cardboard-java",
42 "//third_party/custom_tabs_client:custom_tabs_client_shared_lib", 40 "//third_party/custom_tabs_client:custom_tabs_client_shared_lib",
43 "//third_party/custom_tabs_client:custom_tabs_support_lib", 41 "//third_party/custom_tabs_client:custom_tabs_support_lib",
44 "//third_party/errorprone:chromium_errorprone", 42 "//third_party/errorprone:chromium_errorprone",
45 "//third_party/haha:haha", 43 "//third_party/haha:haha",
46 "//third_party/junit:hamcrest", 44 "//third_party/junit:hamcrest",
47 "//third_party/netty4:netty_all", 45 "//third_party/netty4:netty_all",
48 "//third_party/netty-tcnative:netty-tcnative", 46 "//third_party/netty-tcnative:netty-tcnative",
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
1731 } 1729 }
1732 } 1730 }
1733 1731
1734 template("java_prebuilt_impl") { 1732 template("java_prebuilt_impl") {
1735 set_sources_assignment_filter([]) 1733 set_sources_assignment_filter([])
1736 forward_variables_from(invoker, [ "testonly" ]) 1734 forward_variables_from(invoker, [ "testonly" ])
1737 _supports_android = 1735 _supports_android =
1738 defined(invoker.supports_android) && invoker.supports_android 1736 defined(invoker.supports_android) && invoker.supports_android
1739 1737
1740 assert(defined(invoker.jar_path)) 1738 assert(defined(invoker.jar_path))
1739 if (defined(invoker.output_name)) {
1740 _output_name = invoker.output_name
1741 } else {
1742 _output_name = get_path_info(invoker.jar_path, "name")
1743 }
1741 _base_path = "${target_gen_dir}/$target_name" 1744 _base_path = "${target_gen_dir}/$target_name"
1742 1745
1743 # Jar files can be needed at runtime (by Robolectric tests or java binaries) , 1746 # Jar files can be needed at runtime (by Robolectric tests or java binaries) ,
1744 # so do not put them under gen/. 1747 # so do not put them under gen/.
1745 _target_dir_name = get_label_info(":$target_name", "dir") 1748 _target_dir_name = get_label_info(":$target_name", "dir")
1746 _jar_path = "$root_out_dir/lib.java$_target_dir_name/$target_name.jar" 1749 _jar_path = "$root_out_dir/lib.java$_target_dir_name/$_output_name.jar"
1747 _ijar_path = 1750 _ijar_path =
1748 "$root_out_dir/lib.java$_target_dir_name/$target_name.interface.jar" 1751 "$root_out_dir/lib.java$_target_dir_name/$_output_name.interface.jar"
1749 _build_config = _base_path + ".build_config" 1752 _build_config = _base_path + ".build_config"
1750 1753
1751 if (_supports_android) { 1754 if (_supports_android) {
1752 _dex_path = _base_path + ".dex.jar" 1755 _dex_path = _base_path + ".dex.jar"
1753 } 1756 }
1754 _deps = [] 1757 _deps = []
1755 if (defined(invoker.deps)) { 1758 if (defined(invoker.deps)) {
1756 _deps = invoker.deps 1759 _deps = invoker.deps
1757 } 1760 }
1758 _jar_deps = [] 1761 _jar_deps = []
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
2166 forward_variables_from(invoker, [ "testonly" ]) 2169 forward_variables_from(invoker, [ "testonly" ])
2167 _accumulated_deps = [] 2170 _accumulated_deps = []
2168 if (defined(invoker.deps)) { 2171 if (defined(invoker.deps)) {
2169 _accumulated_deps = invoker.deps 2172 _accumulated_deps = invoker.deps
2170 } 2173 }
2171 2174
2172 assert(defined(invoker.java_files) || defined(invoker.srcjars) || 2175 assert(defined(invoker.java_files) || defined(invoker.srcjars) ||
2173 defined(invoker.srcjar_deps)) 2176 defined(invoker.srcjar_deps))
2174 _base_path = "$target_gen_dir/$target_name" 2177 _base_path = "$target_gen_dir/$target_name"
2175 2178
2179 if (defined(invoker.output_name)) {
2180 _output_name = invoker.output_name
2181 } else {
2182 _output_name = target_name
2183 }
2184
2176 # Jar files can be needed at runtime (by Robolectric tests or java binaries) , 2185 # Jar files can be needed at runtime (by Robolectric tests or java binaries) ,
2177 # so do not put them under gen/. 2186 # so do not put them under gen/.
2178 _jar_name = target_name
2179 if (defined(invoker.jar_name)) {
2180 _jar_name = invoker.jar_name
2181 }
2182 target_dir_name = get_label_info(":$target_name", "dir") 2187 target_dir_name = get_label_info(":$target_name", "dir")
2183 _jar_path = "$root_out_dir/lib.java$target_dir_name/$_jar_name.jar" 2188 _jar_path = "$root_out_dir/lib.java$target_dir_name/$_output_name.jar"
2184 if (defined(invoker.jar_path)) { 2189 if (defined(invoker.jar_path)) {
2185 _jar_path = invoker.jar_path 2190 _jar_path = invoker.jar_path
2186 } 2191 }
2187 _template_name = target_name 2192 _template_name = target_name
2188 2193
2189 _final_deps = [] 2194 _final_deps = []
2190 2195
2191 _supports_android = 2196 _supports_android =
2192 defined(invoker.supports_android) && invoker.supports_android 2197 defined(invoker.supports_android) && invoker.supports_android
2193 _requires_android = 2198 _requires_android =
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
2699 rebase_path(root_build_dir, root_build_dir), 2704 rebase_path(root_build_dir, root_build_dir),
2700 "--packed-libraries-dir", 2705 "--packed-libraries-dir",
2701 rebase_path(_packed_libraries_dir, root_build_dir), 2706 rebase_path(_packed_libraries_dir, root_build_dir),
2702 "--libraries=${invoker.libraries_filearg}", 2707 "--libraries=${invoker.libraries_filearg}",
2703 "--filelistjson", 2708 "--filelistjson",
2704 rebase_path(invoker.file_list_json, root_build_dir), 2709 rebase_path(invoker.file_list_json, root_build_dir),
2705 ] 2710 ]
2706 } 2711 }
2707 } 2712 }
2708 } 2713 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698