Fix java target naming exceptions in third_party/

Fix java target naming exceptions in third_party/

BUG=620034
Committed: https://crrev.com/64b310827fc8b5eaa9e8784370d19c1b0f71a700
Cr-Commit-Position: refs/heads/master@{#431975}

[agrieve, 2016-11-03 17:16:58]

agrieve@chromium.org changed reviewers:
+ mef@chromium.org, mikecase@chromium.org, yusufo@chromium.org

[agrieve, 2016-11-03 17:16:58]

yusufo@chromium.org: Please review changes in cct

mikecase@chromium.org: Please review changes in robolectric

mef@chromium.org: Please review changes in cronet

[mikecase (-- gone --), 2016-11-03 17:36:03]

https://codereview.chromium.org/2473963003/diff/1/third_party/robolectric/BUI...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2473963003/diff/1/third_party/robolectric/BUI...
third_party/robolectric/BUILD.gn:20: java_prebuilt("tagsoup-1.2_java") {
I think these changes will break Robolectric. I would try running any of the
robolectric unit tests (e.g. chrome_junit_tests).

The original reason for these terrible names is that Robolectric looks for some
of these Jars by name....

https://github.com/robolectric/robolectric/blob/21b0dc3dbadf96bd5267f382ff136...

So, for example, it will look for tagsoup-1.2.java. I think with your change
this target will now create a jar named tagsoup-1.2_java.jar and I think
Robolectric will complain because it cant find it.

[agrieve, 2016-11-03 18:03:53]

https://codereview.chromium.org/2473963003/diff/1/third_party/robolectric/BUI...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2473963003/diff/1/third_party/robolectric/BUI...
third_party/robolectric/BUILD.gn:20: java_prebuilt("tagsoup-1.2_java") {
On 2016/11/03 17:36:03, mikecase wrote:
> I think these changes will break Robolectric. I would try running any of the
> robolectric unit tests (e.g. chrome_junit_tests).
> 
> The original reason for these terrible names is that Robolectric looks for
some
> of these Jars by name....
> 
>
https://github.com/robolectric/robolectric/blob/21b0dc3dbadf96bd5267f382ff136...
> 
> So, for example, it will look for tagsoup-1.2.java. I think with your change
> this target will now create a jar named tagsoup-1.2_java.jar and I think
> Robolectric will complain because it cant find it.

Gotcha. I'll have to think more about how to address these then. Reverted for
now.

[mef, 2016-11-04 15:52:39]

components/cronet and third_party/netty* lgtm

[agrieve, 2016-11-10 21:18:03]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 21:18:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:04:46]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-11-11 18:09:58]

ping yusuf

https://codereview.chromium.org/2473963003/diff/1/third_party/robolectric/BUI...
File third_party/robolectric/BUILD.gn (right):

https://codereview.chromium.org/2473963003/diff/1/third_party/robolectric/BUI...
third_party/robolectric/BUILD.gn:20: java_prebuilt("tagsoup-1.2_java") {
On 2016/11/03 18:03:53, agrieve wrote:
> On 2016/11/03 17:36:03, mikecase wrote:
> > I think these changes will break Robolectric. I would try running any of the
> > robolectric unit tests (e.g. chrome_junit_tests).
> > 
> > The original reason for these terrible names is that Robolectric looks for
> some
> > of these Jars by name....
> > 
> >
>
https://github.com/robolectric/robolectric/blob/21b0dc3dbadf96bd5267f382ff136...
> > 
> > So, for example, it will look for tagsoup-1.2.java. I think with your change
> > this target will now create a jar named tagsoup-1.2_java.jar and I think
> > Robolectric will complain because it cant find it.
> 
> Gotcha. I'll have to think more about how to address these then. Reverted for
> now.

Now that java_prebuilt uses the jar name rather than the target name, I suspect
these changes will be fine (at least the dry run passed).

[Yusuf, 2016-11-14 19:18:28]

lgtm

[mikecase (-- gone --), 2016-11-14 19:24:47]

lgtm

[agrieve, 2016-11-14 19:25:39]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-11-14 19:25:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2473963003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-14 19:26:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:39:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-14 23:43:48]

Description was changed from

==========
Fix java target naming exceptions in third_party/

BUG=620034
==========

to

==========
Fix java target naming exceptions in third_party/

BUG=620034

Committed: https://crrev.com/64b310827fc8b5eaa9e8784370d19c1b0f71a700
Cr-Commit-Position: refs/heads/master@{#431975}
==========

[commit-bot: I haz the power, 2016-11-14 23:43:50]

Patchset 2 (id:??) landed as
https://crrev.com/64b310827fc8b5eaa9e8784370d19c1b0f71a700
Cr-Commit-Position: refs/heads/master@{#431975}