Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: build/config/android/rules.gni

Issue 2473963003: Fix java target naming exceptions in third_party/ (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build/config/android/config.gni") 7 import("//build/config/android/config.gni")
8 import("//build/config/android/internal_rules.gni") 8 import("//build/config/android/internal_rules.gni")
9 import("//build/config/compiler/compiler.gni") 9 import("//build/config/compiler/compiler.gni")
10 import("//build/config/dcheck_always_on.gni") 10 import("//build/config/dcheck_always_on.gni")
(...skipping 1602 matching lines...) Expand 10 before | Expand all | Expand 10 after
1613 android_manifest = _android_manifest 1613 android_manifest = _android_manifest
1614 1614
1615 deps = _android_manifest_deps 1615 deps = _android_manifest_deps
1616 1616
1617 if (defined(invoker.deps)) { 1617 if (defined(invoker.deps)) {
1618 possible_config_deps = invoker.deps 1618 possible_config_deps = invoker.deps
1619 } 1619 }
1620 1620
1621 # Added emma to the target's classpath via its .build_config. 1621 # Added emma to the target's classpath via its .build_config.
1622 if (emma_coverage && !_emma_never_instrument) { 1622 if (emma_coverage && !_emma_never_instrument) {
1623 possible_config_deps += [ "//third_party/android_tools:emma_device" ] 1623 possible_config_deps +=
1624 [ "//third_party/android_tools:emma_device_java" ]
1624 } 1625 }
1625 1626
1626 proguard_enabled = _proguard_enabled 1627 proguard_enabled = _proguard_enabled
1627 if (_proguard_enabled) { 1628 if (_proguard_enabled) {
1628 proguard_info = "$_proguard_output_jar_path.info" 1629 proguard_info = "$_proguard_output_jar_path.info"
1629 } 1630 }
1630 1631
1631 # Don't depend on the runtime_deps target in order to avoid having to 1632 # Don't depend on the runtime_deps target in order to avoid having to
1632 # build the native libraries just to create the .build_config file. 1633 # build the native libraries just to create the .build_config file.
1633 # The dep is unnecessary since the runtime_deps file is created by gn gen 1634 # The dep is unnecessary since the runtime_deps file is created by gn gen
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
1778 dex_path = _lib_dex_path 1779 dex_path = _lib_dex_path
1779 emma_never_instrument = _emma_never_instrument 1780 emma_never_instrument = _emma_never_instrument
1780 1781
1781 if (defined(invoker.deps)) { 1782 if (defined(invoker.deps)) {
1782 deps += invoker.deps 1783 deps += invoker.deps
1783 } 1784 }
1784 if (defined(invoker.apk_under_test)) { 1785 if (defined(invoker.apk_under_test)) {
1785 deps += [ "${invoker.apk_under_test}__java" ] 1786 deps += [ "${invoker.apk_under_test}__java" ]
1786 } 1787 }
1787 if (emma_coverage && !_emma_never_instrument) { 1788 if (emma_coverage && !_emma_never_instrument) {
1788 deps += [ "//third_party/android_tools:emma_device" ] 1789 deps += [ "//third_party/android_tools:emma_device_java" ]
1789 } 1790 }
1790 } 1791 }
1791 1792
1792 # TODO(cjhopman): This is only ever needed to calculate the list of tests to 1793 # TODO(cjhopman): This is only ever needed to calculate the list of tests to
1793 # run. See build/android/pylib/instrumentation/test_jar.py. We should be 1794 # run. See build/android/pylib/instrumentation/test_jar.py. We should be
1794 # able to just do that calculation at build time instead. 1795 # able to just do that calculation at build time instead.
1795 if (defined(invoker.create_dist_ijar) && invoker.create_dist_ijar) { 1796 if (defined(invoker.create_dist_ijar) && invoker.create_dist_ijar) {
1796 _dist_ijar_path = "$root_build_dir/test.lib.java/" + 1797 _dist_ijar_path = "$root_build_dir/test.lib.java/" +
1797 get_path_info(_final_apk_path, "name") + ".jar" 1798 get_path_info(_final_apk_path, "name") + ".jar"
1798 action("${_template_name}_dist_ijar") { 1799 action("${_template_name}_dist_ijar") {
(...skipping 969 matching lines...) Expand 10 before | Expand all | Expand 10 after
2768 # because in practice they seem to contain classes required to be in the 2769 # because in practice they seem to contain classes required to be in the
2769 # classpath. 2770 # classpath.
2770 deps += _subjar_targets 2771 deps += _subjar_targets
2771 } 2772 }
2772 if (defined(_res_target_name)) { 2773 if (defined(_res_target_name)) {
2773 deps += [ ":$_res_target_name" ] 2774 deps += [ ":$_res_target_name" ]
2774 } 2775 }
2775 } 2776 }
2776 } 2777 }
2777 } 2778 }
OLDNEW
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/secondary/third_party/android_tools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698