content/public/browser/gpu_utils.cc - Issue 2473933002: Enable WebGL 2 by default! (on desktop)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/gpu_utils.cc

Issue 2473933002: Enable WebGL 2 by default! (on desktop) (Closed)

Patch Set: fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/common/gpu_host_messages.h ('k') | content/test/gpu/gpu_tests/pixel_expectations.py » ('j') | gpu/command_buffer/service/gpu_preferences.h » ('J')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/public/browser/gpu_utils.h"	5 #include "content/public/browser/gpu_utils.h"

6	6

7 #include "base/command_line.h"	7 #include "base/command_line.h"

8 #include "base/strings/string_number_conversions.h"	8 #include "base/strings/string_number_conversions.h"

9 #include "content/public/common/content_switches.h"	9 #include "content/public/common/content_switches.h"

10 #include "gpu/command_buffer/service/gpu_switches.h"	10 #include "gpu/command_buffer/service/gpu_switches.h"

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
98 gpu_preferences.enable_threaded_texture_mailboxes =	98 gpu_preferences.enable_threaded_texture_mailboxes =

99 command_line->HasSwitch(switches::kEnableThreadedTextureMailboxes);	99 command_line->HasSwitch(switches::kEnableThreadedTextureMailboxes);

100 gpu_preferences.gl_shader_interm_output =	100 gpu_preferences.gl_shader_interm_output =

101 command_line->HasSwitch(switches::kGLShaderIntermOutput);	101 command_line->HasSwitch(switches::kGLShaderIntermOutput);

102 gpu_preferences.emulate_shader_precision =	102 gpu_preferences.emulate_shader_precision =

103 command_line->HasSwitch(switches::kEmulateShaderPrecision);	103 command_line->HasSwitch(switches::kEmulateShaderPrecision);

104 gpu_preferences.enable_gpu_service_logging =	104 gpu_preferences.enable_gpu_service_logging =

105 command_line->HasSwitch(switches::kEnableGPUServiceLogging);	105 command_line->HasSwitch(switches::kEnableGPUServiceLogging);

106 gpu_preferences.enable_gpu_service_tracing =	106 gpu_preferences.enable_gpu_service_tracing =

107 command_line->HasSwitch(switches::kEnableGPUServiceTracing);	107 command_line->HasSwitch(switches::kEnableGPUServiceTracing);

108 gpu_preferences.enable_unsafe_es3_apis =

109 command_line->HasSwitch(switches::kEnableUnsafeES3APIs) &&

110 !command_line->HasSwitch(switches::kDisableES3APIs);
Ken Russell (switch to Gerrit) 2016/11/03 21:50:42 Could you add a comment here (perhaps at the very Could you add a comment here (perhaps at the very end) that some of these preferences, including enable_es3_apis, are adjusted in GpuDataManagerImplPrivate::AppendGpuCommandLine ? Kai Ninomiya 2016/11/03 22:10:06 Done. Show quoted text On 2016/11/03 21:50:42, Ken Russell wrote: > Could you add a comment here (perhaps at the very end) that some of these > preferences, including enable_es3_apis, are adjusted in > GpuDataManagerImplPrivate::AppendGpuCommandLine ? Done.
111 gpu_preferences.use_passthrough_cmd_decoder =	108 gpu_preferences.use_passthrough_cmd_decoder =

112 command_line->HasSwitch(switches::kUsePassthroughCmdDecoder);	109 command_line->HasSwitch(switches::kUsePassthroughCmdDecoder);

113 return gpu_preferences;	110 return gpu_preferences;

114 }	111 }

115	112

116 } // namespace content	113 } // namespace content

OLD	NEW