Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/browser/chromeos/policy/heartbeat_scheduler.cc

Issue 2473813002: Notify GCMAppHandlers when the store is reset, so they clear cached IDs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/heartbeat_scheduler.cc
diff --git a/chrome/browser/chromeos/policy/heartbeat_scheduler.cc b/chrome/browser/chromeos/policy/heartbeat_scheduler.cc
index 6782c70d408e8dd6e693c53d8c05ebc86071abc2..92148858acc2264e9c900a5102d17335be369f45 100644
--- a/chrome/browser/chromeos/policy/heartbeat_scheduler.cc
+++ b/chrome/browser/chromeos/policy/heartbeat_scheduler.cc
@@ -424,6 +424,11 @@ void HeartbeatScheduler::ShutdownHandler() {
NOTREACHED() << "HeartbeatScheduler should be destroyed before GCMDriver";
}
+void HeartbeatScheduler::OnStoreReset() {
+ // Nothing to do here since HeartbeatScheduler doesn't locally persist
+ // registration ID, instead it just re-registers.
Peter Beverloo 2016/11/03 17:28:56 registration_id_?
Peter Beverloo 2016/11/03 17:28:56 What about CloudPolicyClient::UpdateGcmId()? There
johnme 2016/11/08 19:22:41 Done.
johnme 2016/11/08 19:22:41 Done - I now call ShutdownGCM.
+}
+
void HeartbeatScheduler::OnMessage(const std::string& app_id,
const gcm::IncomingMessage& message) {
// Should never be called because we don't get any incoming messages

Powered by Google App Engine
This is Rietveld 408576698