Notify GCMAppHandlers when the store is reset, so they clear cached IDs

chrome/browser/chromeos/policy/heartbeat_scheduler.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/heartbeat_scheduler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 406 matching lines @@
 
 void HeartbeatScheduler::ShutdownHandler() {
   // This should never be called, because BrowserProcessImpl::StartTearDown()
   // should shutdown the BrowserPolicyConnector (which destroys this object)
   // before the GCMDriver. Our goal is to make sure that this object is always
   // shutdown before GCMDriver is shut down, rather than trying to handle the
   // case when GCMDriver goes away.
   NOTREACHED() << "HeartbeatScheduler should be destroyed before GCMDriver";
 }
 
+void HeartbeatScheduler::OnStoreReset() {
+  // Nothing to do here since HeartbeatScheduler doesn't locally persist
+  // registration ID, instead it just re-registers.

[Peter Beverloo, 2016/11/03 17:28:56]

registration_id_?

[Peter Beverloo, 2016/11/03 17:28:56]

What about CloudPolicyClient::UpdateGcmId()? There's a TODO on line 331 that
says we send the IDs to the server. It also says we re-send it each time anyway.

Up to the OWNERS, but what about mimicking that TODO?

[johnme, 2016/11/08 19:22:41]

Done.

[johnme, 2016/11/08 19:22:41]

Done - I now call ShutdownGCM.

+}
+
 void HeartbeatScheduler::OnMessage(const std::string& app_id,
                                    const gcm::IncomingMessage& message) {
   // Should never be called because we don't get any incoming messages
   // for our app ID.
   NOTREACHED() << "Received incoming message for " << app_id;
 }
 
 void HeartbeatScheduler::OnMessagesDeleted(const std::string& app_id) {
 }
 
@@ skipping 11 matching lines @@
 void HeartbeatScheduler::OnConnected(const net::IPEndPoint&) {
   SignUpUpstreamNotification();
 }
 
 void HeartbeatScheduler::OnGcmIdUpdateRequestSent(bool success) {
   // TODO(binjin): Handle the failure, probably by exponential backoff.
   LOG_IF(WARNING, !success) << "Failed to send GCM id to DM server";
 }
 
 }  // namespace policy