Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2473593003: VM: [Kernel] Remove special-casing in FGB which is now handled by the frontend (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Remove special-casing in FGB which is now handled by the frontend R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/ab172a32d9536b7a45bada975213ab7f54e4db72

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -36 lines) Patch
M runtime/vm/kernel_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 6 chunks +12 lines, -34 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
kustermann
https://codereview.chromium.org/2473593003/diff/1/runtime/vm/kernel_to_il.cc File runtime/vm/kernel_to_il.cc (left): https://codereview.chromium.org/2473593003/diff/1/runtime/vm/kernel_to_il.cc#oldcode4059 runtime/vm/kernel_to_il.cc:4059: // TODO(27590): figure out how to trigger this case ...
4 years, 1 month ago (2016-11-02 18:41:34 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-02 18:48:28 UTC) #3
kustermann
4 years, 1 month ago (2016-11-02 18:54:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab172a32d9536b7a45bada975213ab7f54e4db72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698