Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: runtime/vm/kernel_reader.cc

Issue 2473593003: VM: [Kernel] Remove special-casing in FGB which is now handled by the frontend (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/kernel_to_il.cc » ('j') | runtime/vm/kernel_to_il.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.cc
diff --git a/runtime/vm/kernel_reader.cc b/runtime/vm/kernel_reader.cc
index aa2d8138833a0ca4745e0a4c0299eadb1779765a..d9d767975ec4df9d6c4c2588315508368e96cf8e 100644
--- a/runtime/vm/kernel_reader.cc
+++ b/runtime/vm/kernel_reader.cc
@@ -253,8 +253,8 @@ void KernelReader::ReadPreliminaryClass(dart::Class* klass,
// Step b) Fill in the bounds of all [TypeParameter]s.
for (intptr_t i = 0; i < num_type_parameters; i++) {
TypeParameter* kernel_parameter = kernel_klass->type_parameters()[i];
- // There is no dynamic bound, only Object.
- // TODO(27590): Should we fix this in the kernel IR generator?
+ // TODO(github.com/dart-lang/kernel/issues/42): This should be handled
+ // by the frontend.
if (kernel_parameter->bound()->IsDynamicType()) {
parameter ^= type_parameters.TypeAt(i);
parameter.set_bound(Type::Handle(Z, I->object_store()->object_type()));
« no previous file with comments | « no previous file | runtime/vm/kernel_to_il.cc » ('j') | runtime/vm/kernel_to_il.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698