components/offline_pages/background/mark_attempt_completed_task.h - Issue 2473553004: Request Picker task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/mark_attempt_completed_task.h

Issue 2473553004: Request Picker task (Closed)

Patch Set: Replace use of header file with forward declare for enum Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/mark_attempt_completed_task.h

diff --git a/components/offline_pages/background/mark_attempt_completed_task.h b/components/offline_pages/background/mark_attempt_completed_task.h

index 7997ee5e0298bb2139747861451b67122649eedc..7e94803a34b3fb9811079ca748da9423e7d7be1e 100644

--- a/components/offline_pages/background/mark_attempt_completed_task.h

+++ b/components/offline_pages/background/mark_attempt_completed_task.h

@@ -8,6 +8,7 @@

#include <stdint.h>

#include <memory>

+#include "components/offline_pages/background/request_queue_results.h"

#include "components/offline_pages/background/request_queue_store.h"

fgorski 2016/11/09 17:58:06 nit: forward declare RequestQueueStore and remove

Pete Williamson 2016/11/09 23:53:55 Done. Would you like me to aslo make a parallel c

fgorski 2016/11/10 19:15:50 Not right now. If you can avoid adding files to th

#include "components/offline_pages/background/update_request_task.h"

#include "components/offline_pages/core/task.h"