Request Picker task

components/offline_pages/background/mark_attempt_completed_task.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_MARK_ATTEMPT_COMPLETED_TASK_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_MARK_ATTEMPT_COMPLETED_TASK_H_
 
 #include <stdint.h>
 #include <memory>
 
+#include "components/offline_pages/background/request_queue_results.h"
 #include "components/offline_pages/background/request_queue_store.h"

[fgorski, 2016/11/09 17:58:06]

nit: forward declare RequestQueueStore and remove this header. It was here for
UdpateRequestsResult as much as for the store. You can remove it now.

[Pete Williamson, 2016/11/09 23:53:55]

Done.  Would you like me to aslo make a parallel change in MarkAttemptStarted
and MarkAttemptAborted?  (I don't have them open for this change, but I could
add them.)

[fgorski, 2016/11/10 19:15:50]

Not right now. If you can avoid adding files to this changelist that would
probably be better for your productivity.

You are welcome to start a new CL for clean up thou.

 #include "components/offline_pages/background/update_request_task.h"
 #include "components/offline_pages/core/task.h"
 
 namespace offline_pages {
 
 class MarkAttemptCompletedTask : public UpdateRequestTask {
  public:
   MarkAttemptCompletedTask(RequestQueueStore* store,
                            int64_t request_id,
                            const RequestQueueStore::UpdateCallback& callback);
   ~MarkAttemptCompletedTask() override;
 
  protected:
   // UpdateRequestTask implementation:
   void UpdateRequestImpl(std::unique_ptr<UpdateRequestsResult> result) override;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_MARK_ATTEMPT_COMPLETED_TASK_H_