Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify and remove the
now unused toJSONValue function from JSONValuesForV8.

This patch also changes JSON::Stringify usage pointed
out by haraken in r429175 review.

Committed: https://crrev.com/cbb06635b3a3fb3d391c3a1c377e9397d0bbc871
Cr-Commit-Position: refs/heads/master@{#429300}

[rwlbuis, 2016-11-02 13:54:02]

Description was changed from

==========
JSON WIP


Use JSON::Stringify instead of JSONValue

Use JSON::Stringify instead of JSONValue. Keep the old
behavior to not accept Arrays.

BUG=602659

patch from issue 2463203002 at patchset 20001
(http://crrev.com/2463203002#ps20001)
==========

to

==========
JSON WIP
==========

[rwlbuis, 2016-11-02 13:57:22]

Description was changed from

==========
JSON WIP
==========

to

==========
Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify and remove the
now unused toJSONValue function from JSONValuesForV8.

This patch also changes JSON::Stringify usage pointed
out by haraken in r429175 review.
==========

[rwlbuis, 2016-11-02 14:32:10]

rob.buis@samsung.com changed reviewers:
+ haraken@chromium.org, kenneth.r.christiansen@intel.com, rouslan@chromium.org

[rwlbuis, 2016-11-02 14:32:11]

@haraken PTAL, this has the changes you suggested in r429175 review.

[haraken, 2016-11-02 14:52:00]

LGTM

[rwlbuis, 2016-11-02 14:59:33]

On 2016/11/02 14:52:00, haraken wrote:
> LGTM

Thanks!

@Rouslan IIRC you added JSONValuesForV8.*. After this change only fromJSONString
is left and no actual JSONValue is used:
- should we rename the file name to not mention JSONValue?
- or should we move fromJSONString somewhere else and delete JSONValuesForV8.*?
If so where?

[please use gerrit instead, 2016-11-02 15:01:30]

The name and location of this file is controlled by haraken@.

[haraken, 2016-11-02 15:03:10]

Yeah, this is only one function, so maybe we can move it to V8Binding.{h,cpp}?

[rwlbuis, 2016-11-02 15:05:57]

On 2016/11/02 15:01:30, rouslan wrote:
> The name and location of this file is controlled by haraken@.

Thanks.

@haraken feel free to pick this up further if it is a good fit, I ended up here
because of PaymentRequest and that bug is fixed now.
One more thing about JSONValuesForV8.* , I noticed there are some places that do
not go through fromJSONString but could:
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp:   
  if (v8Call(v8::JSON::Parse(isolate, jsonSource.v8Value()), json,
third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp:  if
(!v8Call(v8::JSON::Parse(isolate, dataString), parsed, block)) {
third_party/WebKit/Source/modules/fetch/Body.cpp:    if
(v8Call(v8::JSON::Parse(isolate, inputString), parsed, trycatch))
third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp:  if
(v8Call(v8::JSON::Parse(scriptState->isolate(), jsonString),

[rwlbuis, 2016-11-02 15:06:55]

On 2016/11/02 15:03:10, haraken wrote:
> Yeah, this is only one function, so maybe we can move it to V8Binding.{h,cpp}?

Sounds good, let me know if you want to do it or I should. If you do it I can
review of course :)

[haraken, 2016-11-02 15:08:30]

On 2016/11/02 15:06:55, rwlbuis wrote:
> On 2016/11/02 15:03:10, haraken wrote:
> > Yeah, this is only one function, so maybe we can move it to
V8Binding.{h,cpp}?
> 
> Sounds good, let me know if you want to do it or I should. If you do it I can
> review of course :)

If you do it, that's awesome :)

[rwlbuis, 2016-11-02 15:09:10]

On 2016/11/02 15:08:30, haraken wrote:
> On 2016/11/02 15:06:55, rwlbuis wrote:
> > On 2016/11/02 15:03:10, haraken wrote:
> > > Yeah, this is only one function, so maybe we can move it to
> V8Binding.{h,cpp}?
> > 
> > Sounds good, let me know if you want to do it or I should. If you do it I
can
> > review of course :)
> 
> If you do it, that's awesome :)

Ok I'll see what I can do :)

[rwlbuis, 2016-11-02 15:09:14]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-02 15:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 16:34:21]

Description was changed from

==========
Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify and remove the
now unused toJSONValue function from JSONValuesForV8.

This patch also changes JSON::Stringify usage pointed
out by haraken in r429175 review.
==========

to

==========
Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify and remove the
now unused toJSONValue function from JSONValuesForV8.

This patch also changes JSON::Stringify usage pointed
out by haraken in r429175 review.
==========

[commit-bot: I haz the power, 2016-11-02 16:34:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-02 16:51:12]

Description was changed from

==========
Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify and remove the
now unused toJSONValue function from JSONValuesForV8.

This patch also changes JSON::Stringify usage pointed
out by haraken in r429175 review.
==========

to

==========
Make NFC.cpp use JSON::Stringify

Make NFC.cpp use JSON::Stringify and remove the
now unused toJSONValue function from JSONValuesForV8.

This patch also changes JSON::Stringify usage pointed
out by haraken in r429175 review.

Committed: https://crrev.com/cbb06635b3a3fb3d391c3a1c377e9397d0bbc871
Cr-Commit-Position: refs/heads/master@{#429300}
==========

[commit-bot: I haz the power, 2016-11-02 16:51:13]

Patchset 4 (id:??) landed as
https://crrev.com/cbb06635b3a3fb3d391c3a1c377e9397d0bbc871
Cr-Commit-Position: refs/heads/master@{#429300}