Make NFC.cpp use JSON::Stringify

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8StringResource.h"
@@ skipping 330 matching lines @@
   String errorMessage;
   if (!PaymentsValidators::isValidErrorMsgFormat(details.error(),
                                                  &errorMessage)) {
     exceptionState.throwTypeError(errorMessage);
   }
 
   return keepShippingOptions;
 }
 
 void validateAndConvertPaymentMethodData(
-    const HeapVector<PaymentMethodData>& paymentMethodData,
+    const HeapVector<PaymentMethodData>& paymentMethodDataVector,
     Vector<PaymentRequest::MethodData>* methodData,
     ExceptionState& exceptionState) {
-  if (paymentMethodData.isEmpty()) {
+  if (paymentMethodDataVector.isEmpty()) {
     exceptionState.throwTypeError(
         "Must specify at least one payment method identifier");
     return;
   }
 
-  for (const auto& pmd : paymentMethodData) {
-    if (pmd.supportedMethods().isEmpty()) {
+  for (const auto& paymentMethodData : paymentMethodDataVector) {
+    if (paymentMethodData.supportedMethods().isEmpty()) {
       exceptionState.throwTypeError(
           "Must specify at least one payment method identifier");
       return;
     }
 
     String stringifiedData = "";
-    if (pmd.hasData() && !pmd.data().isEmpty()) {
-      if (!pmd.data().v8Value()->IsObject() ||
-          pmd.data().v8Value()->IsArray()) {
+    if (paymentMethodData.hasData() && !paymentMethodData.data().isEmpty()) {
+      if (!paymentMethodData.data().v8Value()->IsObject() ||
+          paymentMethodData.data().v8Value()->IsArray()) {
         exceptionState.throwTypeError(
             "Data should be a JSON-serializable object");
         return;
       }
 
-      v8::MaybeLocal<v8::String> value = v8::JSON::Stringify(
-          pmd.data().context(), pmd.data().v8Value().As<v8::Object>());
-      if (value.IsEmpty()) {
+      v8::Local<v8::String> value;
+      if (!v8::JSON::Stringify(
+               paymentMethodData.data().context(),
+               paymentMethodData.data().v8Value().As<v8::Object>())
+               .ToLocal(&value)) {
         exceptionState.throwTypeError(
             "Unable to parse payment method specific data");
         return;
       }
-      stringifiedData = v8StringToWebCoreString<String>(value.ToLocalChecked(),
-                                                        DoNotExternalize);
+      stringifiedData =
+          v8StringToWebCoreString<String>(value, DoNotExternalize);
     }
-    methodData->append(
-        PaymentRequest::MethodData(pmd.supportedMethods(), stringifiedData));
+    methodData->append(PaymentRequest::MethodData(
+        paymentMethodData.supportedMethods(), stringifiedData));
   }
 }
 
 String getSelectedShippingOption(const PaymentDetails& details) {
   String result;
   if (!details.hasShippingOptions())
     return result;
 
   for (int i = details.shippingOptions().size() - 1; i >= 0; --i) {
     if (details.shippingOptions()[i].hasSelected() &&
@@ skipping 454 matching lines @@
   m_completeTimer.stop();
   m_completeResolver.clear();
   m_showResolver.clear();
   m_abortResolver.clear();
   if (m_clientBinding.is_bound())
     m_clientBinding.Close();
   m_paymentProvider.reset();
 }
 
 }  // namespace blink