Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2473523004: Fix expected return type in async functions (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix expected return type in async functions. Also add support for yield* in the type checker. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/kernel/commit/564c53e6c3d1c8cc5cd17e5d4ccced448282dadf

Patch Set 1 #

Patch Set 2 : Fix expected return type from async functions #

Patch Set 3 : Also handle yield* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -4 lines) Patch
M lib/type_checker.dart View 1 2 5 chunks +50 lines, -4 lines 0 comments Download
M lib/type_environment.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A testcases/input/async_function.dart View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A testcases/spec-mode/async_function.baseline.txt View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A testcases/strong-mode/async_function.baseline.txt View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A testcases/type-propagation/async_function.baseline.txt View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years, 1 month ago (2016-11-02 13:45:36 UTC) #3
Kevin Millikin (Google)
LGTM.
4 years, 1 month ago (2016-11-02 14:51:32 UTC) #4
asgerf
4 years, 1 month ago (2016-11-03 14:09:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
564c53e6c3d1c8cc5cd17e5d4ccced448282dadf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698