Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2473493003: [css-grid] mimax(auto, <flex>) should be serialized as <flex> (Closed)

Created:
4 years, 1 month ago by Manuel Rego
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jfernandez, blink-reviews-style_chromium.org, svillar, blink-reviews-css, Manuel Rego, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] mimax(auto, <flex>) should be serialized as <flex> Add a simple if to serialize properly this case. Add new test case to verify it. We can only check it using grid-auto-columns|rows, because grid-template-columns|rows is serialized to the used breadth. BUG=660675 Committed: https://crrev.com/7e941579065975fa2644e2e0d14d96b4e52312bd Cr-Commit-Position: refs/heads/master@{#429252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-get-set.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridLength.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
4 years, 1 month ago (2016-11-02 10:19:38 UTC) #2
svillar
lgtm
4 years, 1 month ago (2016-11-02 10:46:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473493003/1
4 years, 1 month ago (2016-11-02 10:49:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 12:08:39 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 12:10:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e941579065975fa2644e2e0d14d96b4e52312bd
Cr-Commit-Position: refs/heads/master@{#429252}

Powered by Google App Engine
This is Rietveld 408576698