third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2473493003: [css-grid] mimax(auto, <flex>) should be serialized as <flex>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2473493003: [css-grid] mimax(auto, <flex>) should be serialized as <flex> (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt ('k') | third_party/WebKit/Source/core/style/GridLength.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 2d99858cd70a50d93294295a234d955d2b1dbba6..af0f0c3cf40f1fca8abf92558a84da81dabc8e3c 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -865,6 +865,12 @@ static CSSValue* specifiedValueForGridTrackSize(const GridTrackSize& trackSize,

return specifiedValueForGridTrackBreadth(trackSize.minTrackBreadth(),

style);

case MinMaxTrackSizing: {

+ if (trackSize.minTrackBreadth().isAuto() &&

+ trackSize.maxTrackBreadth().isFlex()) {

+ return CSSPrimitiveValue::create(trackSize.maxTrackBreadth().flex(),

+ CSSPrimitiveValue::UnitType::Fraction);

+ }

auto* minMaxTrackBreadths = CSSFunctionValue::create(CSSValueMinmax);

minMaxTrackBreadths->append(*specifiedValueForGridTrackBreadth(

trackSize.minTrackBreadth(), style));