third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h - Issue 2473483012: Move content/child/background_sync to Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 2473483012: Move content/child/background_sync to Blink. (Closed)

Patch Set: Code review changes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/background_sync/SyncManager.cpp ('K') | « third_party/WebKit/public/platform/modules/background_sync/WebSyncRegistration.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

index b8f755021d703f64c2c1d15935f23dc2ab851d60..d750efaa310713e48dd1ce8c586af772d8bdfed5 100644

--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

@@ -66,6 +66,8 @@ class WebServiceWorkerRegistration {

const WebString& value,

WebServiceWorkerProvider*,

std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks>) {}

+ virtual int64_t registrationId() const = 0;

Peter Beverloo 2016/11/08 16:45:11 nit: everything else in this class has empty imple

Peter Beverloo 2016/11/08 16:45:11 micro nit: maybe put this next to scope(), since t

adithyas 2016/11/08 18:26:19 I don't really have a good default value; I would

adithyas 2016/11/08 18:26:19 Done.

};

} // namespace blink