third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h - Issue 2473483012: Move content/child/background_sync to Blink.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 2473483012: Move content/child/background_sync to Blink. (Closed)

Patch Set: Code review changes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/background_sync/SyncManager.cpp ('K') | « third_party/WebKit/public/platform/modules/background_sync/WebSyncRegistration.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebServiceWorkerRegistration_h	5 #ifndef WebServiceWorkerRegistration_h

6 #define WebServiceWorkerRegistration_h	6 #define WebServiceWorkerRegistration_h

7	7

8 #include "public/platform/WebCallbacks.h"	8 #include "public/platform/WebCallbacks.h"

9 #include "public/platform/WebURL.h"	9 #include "public/platform/WebURL.h"

10 #include "public/platform/modules/serviceworker/WebServiceWorkerError.h"	10 #include "public/platform/modules/serviceworker/WebServiceWorkerError.h"

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 bool enable,	59 bool enable,

60 WebServiceWorkerProvider*,	60 WebServiceWorkerProvider*,

61 std::unique_ptr<WebEnableNavigationPreloadCallbacks>) {}	61 std::unique_ptr<WebEnableNavigationPreloadCallbacks>) {}

62 virtual void getNavigationPreloadState(	62 virtual void getNavigationPreloadState(

63 WebServiceWorkerProvider*,	63 WebServiceWorkerProvider*,

64 std::unique_ptr<WebGetNavigationPreloadStateCallbacks>) {}	64 std::unique_ptr<WebGetNavigationPreloadStateCallbacks>) {}

65 virtual void setNavigationPreloadHeader(	65 virtual void setNavigationPreloadHeader(

66 const WebString& value,	66 const WebString& value,

67 WebServiceWorkerProvider*,	67 WebServiceWorkerProvider*,

68 std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks>) {}	68 std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks>) {}

	69

	70 virtual int64_t registrationId() const = 0;
	Peter Beverloo 2016/11/08 16:45:11 nit: everything else in this class has empty imple nit: everything else in this class has empty implementations. I don't know the reason, but why not stay consistent? Peter Beverloo 2016/11/08 16:45:11 micro nit: maybe put this next to scope(), since t micro nit: maybe put this next to scope(), since they're semantically similar adithyas 2016/11/08 18:26:19 I don't really have a good default value; I would Show quoted text On 2016/11/08 16:45:11, Peter Beverloo wrote: > nit: everything else in this class has empty implementations. I don't know the > reason, but why not stay consistent? I don't really have a good default value; I would say -1 based on this: https://cs.chromium.org/chromium/src/content/common/service_worker/service_wo..., but I can't include that header file. adithyas 2016/11/08 18:26:19 Done. Show quoted text On 2016/11/08 16:45:11, Peter Beverloo wrote: > nit: everything else in this class has empty implementations. I don't know the > reason, but why not stay consistent? Done.
69 };	71 };

70	72

71 } // namespace blink	73 } // namespace blink

72	74

73 #endif // WebServiceWorkerRegistration_h	75 #endif // WebServiceWorkerRegistration_h

OLD	NEW