content/child/service_worker/web_service_worker_registration_impl.h - Issue 2473483012: Move content/child/background_sync to Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 2473483012: Move content/child/background_sync to Blink. (Closed)

Patch Set: Remove background_sync_type_converters_unittest Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/blink_platform_impl.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | content/child/service_worker/web_service_worker_registration_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index 30b7790fa45fa3444929d9e6c59538bf07809c81..55f952bdecabc17fc4f3ccaaa25ebc8784775fee 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -67,6 +67,7 @@ class CONTENT_EXPORT WebServiceWorkerRegistrationImpl

std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks> callbacks)

override;

+ int64_t registrationId() const override;

falken 2016/11/11 07:59:17 nit: remove the blank line above (we don't add emp

adithyas 2016/11/11 15:11:56 Done.

iclelland 2016/11/14 18:43:07 Why the duplication here? Can we remove one or the

iclelland 2016/11/14 18:44:02 nm; Now I see the comment in the most recent patch

int64_t registration_id() const;

using WebServiceWorkerRegistrationHandle =