Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.cc

Issue 2473483012: Move content/child/background_sync to Blink. (Closed)
Patch Set: Remove background_sync_type_converters_unittest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/web_service_worker_registration_impl.cc
diff --git a/content/child/service_worker/web_service_worker_registration_impl.cc b/content/child/service_worker/web_service_worker_registration_impl.cc
index 65a04631523ecfe9825227ac252593d8a27d8f72..34be8bd86e14fec040709b7feb270b22c63d673a 100644
--- a/content/child/service_worker/web_service_worker_registration_impl.cc
+++ b/content/child/service_worker/web_service_worker_registration_impl.cc
@@ -191,6 +191,10 @@ int64_t WebServiceWorkerRegistrationImpl::registration_id() const {
return handle_ref_->registration_id();
}
+int64_t WebServiceWorkerRegistrationImpl::registrationId() const {
+ return registration_id();
+}
falken 2016/11/11 07:59:17 For code health, can we remove registration_id() a
falken 2016/11/11 08:08:07 (it's OK to do this as a followup patch, perhaps j
adithyas 2016/11/11 15:11:56 The function is used in 6 other files, so I'll mak
+
// static
std::unique_ptr<blink::WebServiceWorkerRegistration::Handle>
WebServiceWorkerRegistrationImpl::CreateHandle(

Powered by Google App Engine
This is Rietveld 408576698