Simplify SVG pending resource (re)validation

Simplify SVG pending resource (re)validation

The contents of the m_pendingResourcesForRemoval map has a lifespan that
does not extend beyond the scope of SVGElement's
buildPendingResourcesIfNeeded() method.
So instead of passing through the map in SVGDocumentExtensions, just
take the corresponding set for the pending 'id' and iterate that
directly, avoiding indirection and complicated removal sequence.
This also allow SVGDocumentExtensions::removeElementFromPendingResources
to be simplified, so do that, and then remove the
m_pendingResourcesForRemoval map from SVGDocumentExtensions.

BUG=661598
Committed: https://crrev.com/9365003f3f4f921445eeb94413d7a29f996b4148
Cr-Commit-Position: refs/heads/master@{#429539}

[fs, 2016-11-02 16:23:24]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 16:23:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-11-02 17:26:18]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-11-02 18:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 18:50:28]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-11-02 21:55:11]

On 2016/11/02 at 17:26:18, fs wrote:
> 

Nice cleanup. LGTM

[fs, 2016-11-03 08:37:53]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-11-03 08:38:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:42:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 08:44:57]

Description was changed from

==========
Simplify SVG pending resource (re)validation

The contents of the m_pendingResourcesForRemoval map has a lifespan that
does not extend beyond the scope of SVGElement's
buildPendingResourcesIfNeeded() method.
So instead of passing through the map in SVGDocumentExtensions, just
take the corresponding set for the pending 'id' and iterate that
directly, avoiding indirection and complicated removal sequence.
This also allow SVGDocumentExtensions::removeElementFromPendingResources
to be simplified, so do that, and then remove the
m_pendingResourcesForRemoval map from SVGDocumentExtensions.

BUG=661598
==========

to

==========
Simplify SVG pending resource (re)validation

The contents of the m_pendingResourcesForRemoval map has a lifespan that
does not extend beyond the scope of SVGElement's
buildPendingResourcesIfNeeded() method.
So instead of passing through the map in SVGDocumentExtensions, just
take the corresponding set for the pending 'id' and iterate that
directly, avoiding indirection and complicated removal sequence.
This also allow SVGDocumentExtensions::removeElementFromPendingResources
to be simplified, so do that, and then remove the
m_pendingResourcesForRemoval map from SVGDocumentExtensions.

BUG=661598

Committed: https://crrev.com/9365003f3f4f921445eeb94413d7a29f996b4148
Cr-Commit-Position: refs/heads/master@{#429539}
==========

[commit-bot: I haz the power, 2016-11-03 08:44:58]

Patchset 1 (id:??) landed as
https://crrev.com/9365003f3f4f921445eeb94413d7a29f996b4148
Cr-Commit-Position: refs/heads/master@{#429539}