Simplify SVG pending resource (re)validation

third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

 /*
  * Copyright (C) 2006 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 193 matching lines @@
 }
 
 void SVGDocumentExtensions::clearHasPendingResourcesIfPossible(
     Element* element) {
   if (!isElementPendingResources(element))
     element->clearHasPendingResources();
 }
 
 void SVGDocumentExtensions::removeElementFromPendingResources(
     Element* element) {
-  ASSERT(element);
+  DCHECK(element);
 
   // Remove the element from pending resources.
-  if (!m_pendingResources.isEmpty() && element->hasPendingResources()) {
-    Vector<AtomicString> toBeRemoved;
-    for (const auto& entry : m_pendingResources) {
-      SVGPendingElements* elements = entry.value.get();
-      ASSERT(elements);
-      ASSERT(!elements->isEmpty());
+  if (m_pendingResources.isEmpty() || !element->hasPendingResources())
+    return;
 
-      elements->remove(element);
-      if (elements->isEmpty())
-        toBeRemoved.append(entry.key);
-    }
+  Vector<AtomicString> toBeRemoved;
+  for (const auto& entry : m_pendingResources) {
+    SVGPendingElements* elements = entry.value.get();
+    DCHECK(elements);
+    DCHECK(!elements->isEmpty());
 
-    clearHasPendingResourcesIfPossible(element);
-
-    // We use the removePendingResource function here because it deals with set
-    // lifetime correctly.
-    for (const AtomicString& id : toBeRemoved)
-      removePendingResource(id);
+    elements->remove(element);
+    if (elements->isEmpty())
+      toBeRemoved.append(entry.key);
   }
 
-  // Remove the element from pending resources that were scheduled for removal.
-  if (!m_pendingResourcesForRemoval.isEmpty()) {
-    Vector<AtomicString> toBeRemoved;
-    for (const auto& entry : m_pendingResourcesForRemoval) {
-      SVGPendingElements* elements = entry.value.get();
-      ASSERT(elements);
-      ASSERT(!elements->isEmpty());
+  clearHasPendingResourcesIfPossible(element);
 
-      elements->remove(element);
-      if (elements->isEmpty())
-        toBeRemoved.append(entry.key);
-    }
-
-    // We use the removePendingResourceForRemoval function here because it deals
-    // with set lifetime correctly.
-    for (const AtomicString& id : toBeRemoved)
-      removePendingResourceForRemoval(id);
-  }
+  m_pendingResources.removeAll(toBeRemoved);
 }
 
 SVGDocumentExtensions::SVGPendingElements*
 SVGDocumentExtensions::removePendingResource(const AtomicString& id) {
   ASSERT(m_pendingResources.contains(id));
   return m_pendingResources.take(id);
 }
 
-SVGDocumentExtensions::SVGPendingElements*
-SVGDocumentExtensions::removePendingResourceForRemoval(const AtomicString& id) {
-  ASSERT(m_pendingResourcesForRemoval.contains(id));
-  return m_pendingResourcesForRemoval.take(id);
-}
-
-void SVGDocumentExtensions::markPendingResourcesForRemoval(
-    const AtomicString& id) {
-  if (id.isEmpty())
-    return;
-
-  ASSERT(!m_pendingResourcesForRemoval.contains(id));
-
-  Member<SVGPendingElements> existing = m_pendingResources.take(id);
-  if (existing && !existing->isEmpty())
-    m_pendingResourcesForRemoval.add(id, existing.release());
-}
-
-Element* SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval(
-    const AtomicString& id) {
-  if (id.isEmpty())
-    return nullptr;
-
-  SVGPendingElements* resourceSet = m_pendingResourcesForRemoval.get(id);
-  if (!resourceSet || resourceSet->isEmpty())
-    return nullptr;
-
-  SVGPendingElements::iterator firstElement = resourceSet->begin();
-  Element* element = *firstElement;
-
-  resourceSet->remove(firstElement);
-
-  if (resourceSet->isEmpty())
-    removePendingResourceForRemoval(id);
-
-  return element;
-}
-
 void SVGDocumentExtensions::addSVGRootWithRelativeLengthDescendents(
     SVGSVGElement* svgRoot) {
   ASSERT(!m_inRelativeLengthSVGRootsInvalidation);
   m_relativeLengthSVGRoots.add(svgRoot);
 }
 
 void SVGDocumentExtensions::removeSVGRootWithRelativeLengthDescendents(
     SVGSVGElement* svgRoot) {
   ASSERT(!m_inRelativeLengthSVGRootsInvalidation);
   m_relativeLengthSVGRoots.remove(svgRoot);
@@ skipping 43 matching lines @@
   ASSERT(m_document);
   return rootElement(*m_document);
 }
 
 DEFINE_TRACE(SVGDocumentExtensions) {
   visitor->trace(m_document);
   visitor->trace(m_timeContainers);
   visitor->trace(m_webAnimationsPendingSVGElements);
   visitor->trace(m_relativeLengthSVGRoots);
   visitor->trace(m_pendingResources);
-  visitor->trace(m_pendingResourcesForRemoval);
 }
 
 }  // namespace blink