Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2473433002: Don't always have to relayout a child when fragmentainer height is unknown. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't always have to relayout a child when fragmentainer height is unknown. Fragmentainer height is unknown in the first multicol layout pass, before the initial balancing attempt. It also happens when we have to restart the column balancing algorithm (due to dynamic content change, containing block logical width change, etc.). In this case we only need to relayout if the child did previously break (because then there may be pagination stuts inside that we need to clear). Committed: https://crrev.com/4de05710061fa25ca300b18d7ade421161ebe87a Cr-Commit-Position: refs/heads/master@{#429135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-01 20:13:37 UTC) #4
eae
LGTM
4 years, 1 month ago (2016-11-01 20:47:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473433002/1
4 years, 1 month ago (2016-11-01 22:21:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 22:28:42 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 22:30:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4de05710061fa25ca300b18d7ade421161ebe87a
Cr-Commit-Position: refs/heads/master@{#429135}

Powered by Google App Engine
This is Rietveld 408576698