Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2473433002: Don't always have to relayout a child when fragmentainer height is unknown. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 4724 matching lines...) Expand 10 before | Expand all | Expand 10 after
4735 if (child.offsetToNextPage()) { 4735 if (child.offsetToNextPage()) {
4736 // We need to relayout unless we're going to break at the exact same 4736 // We need to relayout unless we're going to break at the exact same
4737 // location as before. 4737 // location as before.
4738 if (child.offsetToNextPage() != remainingSpace) 4738 if (child.offsetToNextPage() != remainingSpace)
4739 return true; 4739 return true;
4740 } else if (logicalHeight > remainingSpace) { 4740 } else if (logicalHeight > remainingSpace) {
4741 // Last time we laid out this child, we didn't need to break, but now we 4741 // Last time we laid out this child, we didn't need to break, but now we
4742 // have to. So we need to relayout. 4742 // have to. So we need to relayout.
4743 return true; 4743 return true;
4744 } 4744 }
4745 } else { 4745 } else if (child.offsetToNextPage()) {
4746 // This child did previously break, but it won't anymore, because we no
4747 // longer have a known fragmentainer height.
4746 return true; 4748 return true;
4747 } 4749 }
4748 4750
4749 // It seems that we can skip layout of this child, but we need to ask the flow 4751 // It seems that we can skip layout of this child, but we need to ask the flow
4750 // thread for permission first. We currently cannot skip over objects 4752 // thread for permission first. We currently cannot skip over objects
4751 // containing column spanners. 4753 // containing column spanners.
4752 LayoutFlowThread* flowThread = child.flowThreadContainingBlock(); 4754 LayoutFlowThread* flowThread = child.flowThreadContainingBlock();
4753 return flowThread && !flowThread->canSkipLayout(child); 4755 return flowThread && !flowThread->canSkipLayout(child);
4754 } 4756 }
4755 4757
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
5638 LayoutRect rect = frameRect(); 5640 LayoutRect rect = frameRect();
5639 5641
5640 LayoutBlock* block = containingBlock(); 5642 LayoutBlock* block = containingBlock();
5641 if (block) 5643 if (block)
5642 block->adjustChildDebugRect(rect); 5644 block->adjustChildDebugRect(rect);
5643 5645
5644 return rect; 5646 return rect;
5645 } 5647 }
5646 5648
5647 } // namespace blink 5649 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698