Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/signin/signin_browsertest.cc

Issue 24733003: Update defaults for InstantExtended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_browsertest.cc
diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc
index d3031c0dbe17e8c47a70db9e55952145c1b684e6..3fa796cd4bc3b668855541322b2b3790a52ed3be 100644
--- a/chrome/browser/signin/signin_browsertest.cc
+++ b/chrome/browser/signin/signin_browsertest.cc
@@ -109,7 +109,7 @@ IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_ProcessIsolation) {
EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
// Navigating away should change the process.
- ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL));
+ ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIOmniboxURL));
EXPECT_FALSE(signin->HasSigninProcess());
ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL(
@@ -136,7 +136,7 @@ IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_ProcessIsolation) {
signin->IsSigninProcess(active_tab_process_id));
// Navigating away should change the process.
- ui_test_utils::NavigateToURL(browser(), GURL(kNonSigninURL));
+ ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIOmniboxURL));
EXPECT_FALSE(signin->IsSigninProcess(
active_tab->GetRenderProcessHost()->GetID()));
}
@@ -192,7 +192,9 @@ class BackOnNTPCommitObserver : public content::WebContentsObserver {
// that occur if the user clicks on the "Skip for now" link at the signin page
// and initiates a back navigation between the point of Commit and
// DidStopLoading of the NTP.
-IN_PROC_BROWSER_TEST_F(SigninBrowserTest, SigninSkipForNowAndGoBack) {
+// TODO(samarth): this test doesn't make sense with a prerendered NTP. But
+// re-enable it when we are using a cached NTP and no longer prerendering it.
+IN_PROC_BROWSER_TEST_F(SigninBrowserTest, DISABLED_SigninSkipForNowAndGoBack) {
GURL ntp_url(chrome::kChromeUINewTabURL);
GURL start_url = signin::GetPromoURL(signin::SOURCE_START_PAGE, true);
GURL skip_url = signin::GetLandingURL("ntp", 1);

Powered by Google App Engine
This is Rietveld 408576698