Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/signin/signin_browsertest.cc

Issue 24733003: Update defaults for InstantExtended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_ 5 #ifndef CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
6 #define CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_ 6 #define CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/browser/signin/signin_manager.h" 9 #include "chrome/browser/signin/signin_manager.h"
10 #include "chrome/browser/signin/signin_manager_factory.h" 10 #include "chrome/browser/signin/signin_manager_factory.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_ProcessIsolation) { 102 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, MAYBE_ProcessIsolation) {
103 SigninManager* signin = SigninManagerFactory::GetForProfile( 103 SigninManager* signin = SigninManagerFactory::GetForProfile(
104 browser()->profile()); 104 browser()->profile());
105 EXPECT_FALSE(signin->HasSigninProcess()); 105 EXPECT_FALSE(signin->HasSigninProcess());
106 106
107 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL( 107 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL(
108 signin::SOURCE_NTP_LINK, true)); 108 signin::SOURCE_NTP_LINK, true));
109 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 109 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
110 110
111 // Navigating away should change the process. 111 // Navigating away should change the process.
112 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL)); 112 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIOmniboxURL));
113 EXPECT_FALSE(signin->HasSigninProcess()); 113 EXPECT_FALSE(signin->HasSigninProcess());
114 114
115 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL( 115 ui_test_utils::NavigateToURL(browser(), signin::GetPromoURL(
116 signin::SOURCE_NTP_LINK, true)); 116 signin::SOURCE_NTP_LINK, true));
117 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 117 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
118 118
119 content::WebContents* active_tab = 119 content::WebContents* active_tab =
120 browser()->tab_strip_model()->GetActiveWebContents(); 120 browser()->tab_strip_model()->GetActiveWebContents();
121 int active_tab_process_id = 121 int active_tab_process_id =
122 active_tab->GetRenderProcessHost()->GetID(); 122 active_tab->GetRenderProcessHost()->GetID();
123 EXPECT_EQ(kOneClickSigninEnabled, 123 EXPECT_EQ(kOneClickSigninEnabled,
124 signin->IsSigninProcess(active_tab_process_id)); 124 signin->IsSigninProcess(active_tab_process_id));
125 EXPECT_EQ(0, active_tab->GetRenderViewHost()->GetEnabledBindings()); 125 EXPECT_EQ(0, active_tab->GetRenderViewHost()->GetEnabledBindings());
126 126
127 // Entry points to signin request "SINGLETON_TAB" mode, so a new request 127 // Entry points to signin request "SINGLETON_TAB" mode, so a new request
128 // shouldn't change anything. 128 // shouldn't change anything.
129 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams( 129 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
130 browser(), 130 browser(),
131 GURL(signin::GetPromoURL(signin::SOURCE_NTP_LINK, false)))); 131 GURL(signin::GetPromoURL(signin::SOURCE_NTP_LINK, false))));
132 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE; 132 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
133 ShowSingletonTabOverwritingNTP(browser(), params); 133 ShowSingletonTabOverwritingNTP(browser(), params);
134 EXPECT_EQ(active_tab, browser()->tab_strip_model()->GetActiveWebContents()); 134 EXPECT_EQ(active_tab, browser()->tab_strip_model()->GetActiveWebContents());
135 EXPECT_EQ(kOneClickSigninEnabled, 135 EXPECT_EQ(kOneClickSigninEnabled,
136 signin->IsSigninProcess(active_tab_process_id)); 136 signin->IsSigninProcess(active_tab_process_id));
137 137
138 // Navigating away should change the process. 138 // Navigating away should change the process.
139 ui_test_utils::NavigateToURL(browser(), GURL(kNonSigninURL)); 139 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIOmniboxURL));
140 EXPECT_FALSE(signin->IsSigninProcess( 140 EXPECT_FALSE(signin->IsSigninProcess(
141 active_tab->GetRenderProcessHost()->GetID())); 141 active_tab->GetRenderProcessHost()->GetID()));
142 } 142 }
143 143
144 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, NotTrustedAfterRedirect) { 144 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, NotTrustedAfterRedirect) {
145 SigninManager* signin = SigninManagerFactory::GetForProfile( 145 SigninManager* signin = SigninManagerFactory::GetForProfile(
146 browser()->profile()); 146 browser()->profile());
147 EXPECT_FALSE(signin->HasSigninProcess()); 147 EXPECT_FALSE(signin->HasSigninProcess());
148 148
149 GURL url = signin::GetPromoURL(signin::SOURCE_NTP_LINK, true); 149 GURL url = signin::GetPromoURL(signin::SOURCE_NTP_LINK, true);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 } 185 }
186 186
187 private: 187 private:
188 DISALLOW_COPY_AND_ASSIGN(BackOnNTPCommitObserver); 188 DISALLOW_COPY_AND_ASSIGN(BackOnNTPCommitObserver);
189 }; 189 };
190 190
191 // This is a test for http://crbug.com/257277. It simulates the navigations 191 // This is a test for http://crbug.com/257277. It simulates the navigations
192 // that occur if the user clicks on the "Skip for now" link at the signin page 192 // that occur if the user clicks on the "Skip for now" link at the signin page
193 // and initiates a back navigation between the point of Commit and 193 // and initiates a back navigation between the point of Commit and
194 // DidStopLoading of the NTP. 194 // DidStopLoading of the NTP.
195 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, SigninSkipForNowAndGoBack) { 195 // TODO(samarth): this test doesn't make sense with a prerendered NTP. But
196 // re-enable it when we are using a cached NTP and no longer prerendering it.
197 IN_PROC_BROWSER_TEST_F(SigninBrowserTest, DISABLED_SigninSkipForNowAndGoBack) {
196 GURL ntp_url(chrome::kChromeUINewTabURL); 198 GURL ntp_url(chrome::kChromeUINewTabURL);
197 GURL start_url = signin::GetPromoURL(signin::SOURCE_START_PAGE, true); 199 GURL start_url = signin::GetPromoURL(signin::SOURCE_START_PAGE, true);
198 GURL skip_url = signin::GetLandingURL("ntp", 1); 200 GURL skip_url = signin::GetLandingURL("ntp", 1);
199 201
200 SigninManager* signin = SigninManagerFactory::GetForProfile( 202 SigninManager* signin = SigninManagerFactory::GetForProfile(
201 browser()->profile()); 203 browser()->profile());
202 EXPECT_FALSE(signin->HasSigninProcess()); 204 EXPECT_FALSE(signin->HasSigninProcess());
203 205
204 ui_test_utils::NavigateToURL(browser(), start_url); 206 ui_test_utils::NavigateToURL(browser(), start_url);
205 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess()); 207 EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
(...skipping 23 matching lines...) Expand all
229 EXPECT_EQ(skip_url, web_contents->GetLastCommittedURL()); 231 EXPECT_EQ(skip_url, web_contents->GetLastCommittedURL());
230 EXPECT_EQ(ntp_url, web_contents->GetVisibleURL()); 232 EXPECT_EQ(ntp_url, web_contents->GetVisibleURL());
231 233
232 content::WindowedNotificationObserver observer( 234 content::WindowedNotificationObserver observer(
233 content::NOTIFICATION_LOAD_STOP, 235 content::NOTIFICATION_LOAD_STOP,
234 content::NotificationService::AllSources()); 236 content::NotificationService::AllSources());
235 observer.Wait(); 237 observer.Wait();
236 EXPECT_EQ(start_url, web_contents->GetLastCommittedURL()); 238 EXPECT_EQ(start_url, web_contents->GetLastCommittedURL());
237 } 239 }
238 #endif // CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_ 240 #endif // CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698