Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2473273005: Revert of [debugger] simplify fetching scripts for inspector. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
kozy, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] simplify fetching scripts for inspector. (patchset #6 id:100001 of https://codereview.chromium.org/2465833002/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11118 Rule of thumb: As long as the tests have not migrated yet, you most certainly need a blink rebase whenever you change expectations. Original issue's description: > [debugger] simplify fetching scripts for inspector. > > The old code path is going to be removed with the debug context api. > > R=kozyatinskiy@chromium.org TBR=kozyatinskiy@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9598e6eb8494e4dc44150b4042497ed34b366bb5 Cr-Commit-Position: refs/heads/master@{#40764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M src/api.cc View 1 chunk +7 lines, -12 lines 0 comments Download
M test/inspector/debugger/script-on-after-compile.js View 2 chunks +4 lines, -4 lines 0 comments Download
M test/inspector/debugger/script-on-after-compile-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [debugger] simplify fetching scripts for inspector.
4 years, 1 month ago (2016-11-04 12:59:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473273005/1
4 years, 1 month ago (2016-11-04 12:59:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 12:59:50 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9598e6eb8494e4dc44150b4042497ed34b366bb5
Cr-Commit-Position: refs/heads/master@{#40764}

Powered by Google App Engine
This is Rietveld 408576698