Ensure WebAPKs installed from the menu do not pollute banner statistics.

Ensure WebAPKs installed from the menu do not pollute banner statistics.

Currently, WebAPKs reuse the AppBannerInfoBarDelegate, even if they are
added via the Add to Homescreen menu item. This means they incorrectly
send app banner metrics when they have not been added from a banner
triggering.

This CL guards all app banner metrics callsites in WebAPK codepaths in
AppBannerInfoBarDelegate to ensure that app banner stats are not
polluted.

BUG=651894
Committed: https://crrev.com/b84e58a2540e004466d0215a0efe4b42b5c3c298
Cr-Commit-Position: refs/heads/master@{#429770}

[dominickn, 2016-11-04 00:59:32]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-11-04 00:59:40]

dominickn@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[dominickn, 2016-11-04 00:59:41]

Peter: PTAL, thanks

[commit-bot: I haz the power, 2016-11-04 01:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2016-11-04 01:34:33]

LGTM with nit. Thank you for cleaning this up!

https://codereview.chromium.org/2473243002/diff/1/chrome/browser/android/bann...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
(right):

https://codereview.chromium.org/2473243002/diff/1/chrome/browser/android/bann...
chrome/browser/android/banners/app_banner_infobar_delegate_android.cc:327: 
Nit: Move the comment on lines 337 - 338 here. The code below belongs to
handling the "Add to Homescreen" button, not the "Open" button button

[commit-bot: I haz the power, 2016-11-04 01:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:41:13]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-04 01:44:47]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-11-04 01:44:51]

Thanks!

https://codereview.chromium.org/2473243002/diff/1/chrome/browser/android/bann...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
(right):

https://codereview.chromium.org/2473243002/diff/1/chrome/browser/android/bann...
chrome/browser/android/banners/app_banner_infobar_delegate_android.cc:327: 
On 2016/11/04 01:34:33, pkotwicz wrote:
> Nit: Move the comment on lines 337 - 338 here. The code below belongs to
> handling the "Add to Homescreen" button, not the "Open" button button

Done.

[commit-bot: I haz the power, 2016-11-04 01:45:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:17:58]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-04 02:25:36]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-11-04 02:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2473243002/#ps20001
(title: "Address nit")

[commit-bot: I haz the power, 2016-11-04 02:26:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:34:08]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-11-04 02:34:28]

Description was changed from

==========
Ensure WebAPKs installed from the menu do not pollute banner statistics.

Currently, WebAPKs reuse the AppBannerInfoBarDelegate, even if they are
added via the Add to Homescreen menu item. This means they incorrectly
send app banner metrics when they have not been added from a banner
triggering.

This CL guards all app banner metrics callsites in WebAPK codepaths in
AppBannerInfoBarDelegate to ensure that app banner stats are not
polluted.

BUG=651894
==========

to

==========
Ensure WebAPKs installed from the menu do not pollute banner statistics.

Currently, WebAPKs reuse the AppBannerInfoBarDelegate, even if they are
added via the Add to Homescreen menu item. This means they incorrectly
send app banner metrics when they have not been added from a banner
triggering.

This CL guards all app banner metrics callsites in WebAPK codepaths in
AppBannerInfoBarDelegate to ensure that app banner stats are not
polluted.

BUG=651894

Committed: https://crrev.com/b84e58a2540e004466d0215a0efe4b42b5c3c298
Cr-Commit-Position: refs/heads/master@{#429770}
==========

[commit-bot: I haz the power, 2016-11-04 02:34:29]

Patchset 2 (id:??) landed as
https://crrev.com/b84e58a2540e004466d0215a0efe4b42b5c3c298
Cr-Commit-Position: refs/heads/master@{#429770}