Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4992)

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.h

Issue 2473243002: Ensure WebAPKs installed from the menu do not pollute banner statistics. (Closed)
Patch Set: Address nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.h
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.h b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
index bb4362c5bc61229fe5465bed095f78effa738f03..a83b9c8ef42d519413253f91387681e695e6e981 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h
@@ -61,13 +61,13 @@ class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
void UpdateInstallState(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
- // Called when the installation Intent has been handled and focus has been
- // returned to Chrome.
+ // Called when the native app installation Intent has been handled and focus
+ // has been returned to Chrome.
void OnInstallIntentReturned(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jboolean jis_installing);
- // Called when the InstallerDelegate task has finished.
+ // Called when the native app InstallerDelegate task has finished.
void OnInstallFinished(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jboolean success);
@@ -117,6 +117,9 @@ class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {
// infobar should be closed as a result of the button press.
bool AcceptWebApk(content::WebContents* web_contents);
+ // Returns false if this delegate is for a WebAPK and was triggered from the
+ // A2HS menu item. Otherwise returns true.
+ bool TriggeredFromBanner() const;
void SendBannerAccepted();
void OnWebApkInstallFinished(bool success,
const std::string& webapk_package_name);
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_infobar_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698