Stop preloading scripts that have invalid type/language attributes

Stop preloading scripts that have invalid type/language attributes

This is a followup on crbug.com/626321, which deprecated the preloading of
scripts that have an invalid type/language attribute. This change will remove
the deprecation and stop prefetching those scripts (and adds tests).

BUG=662085

[cfredric, 2016-11-03 17:46:32]

cfredric@chromium.org changed reviewers:
+ cfredric@chromium.org, csharrison@chromium.org

[Charlie Harrison, 2016-11-03 21:00:41]

Thanks!

https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right):

https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:256: if
(match(m_tagImpl, scriptTag) &&
Can this check be moved to shouldPreload()?

https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
(left):

https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp:99:
UseCounter::ScriptInvalidTypeOrLanguage);
You'll need to remove the ScriptInvalidTypeOrLanguage from UseCounter and all
associated baggage (the deprecation message, etc).

[cfredric, 2016-11-04 14:05:42]

On 2016/11/03 21:00:41, Charlie Harrison wrote:
> Thanks!
> 
>
https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
(right):
> 
>
https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:256: if
> (match(m_tagImpl, scriptTag) &&
> Can this check be moved to shouldPreload()?
> 
>
https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
> (left):
> 
>
https://codereview.chromium.org/2473113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp:99:
> UseCounter::ScriptInvalidTypeOrLanguage);
> You'll need to remove the ScriptInvalidTypeOrLanguage from UseCounter and all
> associated baggage (the deprecation message, etc).

Done. I think I got all the baggage - let me know if I missed anything.

[Charlie Harrison, 2016-11-04 14:37:08]

Looking good! I think there may be some layout tests that need updating as well
to avoid showing the deprecation message. Let's dry-run it (you can also
probably try to find some using codesearch).

https://codereview.chromium.org/2473113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right):

https://codereview.chromium.org/2473113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:484:
ScriptLoader::AllowLegacyTypeInTypeAttribute))
Add { } blocks to the multi-line if statement (this got messed up because blink
style recently automatically changed to 80 col enforcement).

[Charlie Harrison, 2016-11-04 14:37:13]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 14:37:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 16:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:14:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cfredric, 2016-11-04 17:40:33]

I'll start another dry run for this.

https://codereview.chromium.org/2473113002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp (right):

https://codereview.chromium.org/2473113002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp:484:
ScriptLoader::AllowLegacyTypeInTypeAttribute))
On 2016/11/04 14:37:08, Charlie Harrison wrote:
> Add { } blocks to the multi-line if statement (this got messed up because
blink
> style recently automatically changed to 80 col enforcement).

Done.

[cfredric, 2016-11-04 17:40:49]

The CQ bit was checked by cfredric@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 17:41:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...